Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 10835045: Add --spec to the default parameter list. (Closed)

Created:
8 years, 4 months ago by szager1
Modified:
8 years, 4 months ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Add --spec to the default parameter list. This simplifies some of the git-submodule stuff. For example, deps2hooks.bat can be changed from this: @echo off setlocal set TMP_GCLIENT_FILE=.tmp.gclient echo solutions=[{"name":".","url":None,"deps_file":".DEPS.git"}] > %TMP_GCLIENT_FILE% FOR /F "delims=" %%a in ('call gclient hookinfo --gclientfile=%TMP_GCLIENT_FILE%') do set HOOKINFO=%%a set HOOKINFO="call %HOOKINFO:;= & call%" cd .. cmd /c %HOOKINFO% del /F src\%TMP_GCLIENT_FILE% ... to this: @echo off setlocal call gclient runhooks --spec="solutions=[{'name':'src','url':None,'deps_file':'.DEPS.git'}]" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149223

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M gclient.py View 1 2 6 chunks +34 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
szager1
8 years, 4 months ago (2012-07-30 21:13:58 UTC) #1
cmp
lgtm I think there should be a test that verifies that when --spec is passed ...
8 years, 4 months ago (2012-07-30 21:26:34 UTC) #2
szager1
On 2012/07/30 21:26:34, cmp wrote: > lgtm > > I think there should be a ...
8 years, 4 months ago (2012-07-30 21:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/10835045/5002
8 years, 4 months ago (2012-07-31 18:02:27 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 18:05:18 UTC) #5
Change committed as 149223

Powered by Google App Engine
This is Rietveld 408576698