Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 10835036: Not updating the document.title property for open/save dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * FileManager constructor. 6 * FileManager constructor.
7 * 7 *
8 * FileManager objects encapsulate the functionality of the file selector 8 * FileManager objects encapsulate the functionality of the file selector
9 * dialogs, as well as the full screen file manager application (though the 9 * dialogs, as well as the full screen file manager application (though the
10 * latter is not yet implemented). 10 * latter is not yet implemented).
(...skipping 3087 matching lines...) Expand 10 before | Expand all | Expand 10 after
3098 if (replace) 3098 if (replace)
3099 history.replaceState(undefined, path, location); 3099 history.replaceState(undefined, path, location);
3100 else 3100 else
3101 history.pushState(undefined, path, location); 3101 history.pushState(undefined, path, location);
3102 }, 3102 },
3103 3103
3104 /** 3104 /**
3105 * Update the tab title. 3105 * Update the tab title.
3106 */ 3106 */
3107 FileManager.prototype.updateTitle_ = function() { 3107 FileManager.prototype.updateTitle_ = function() {
3108 if (this.dialogType_ != FileManager.DialogType.FULL_PAGE)
3109 return;
3110
3108 this.document_.title = this.getCurrentDirectory().replace( 3111 this.document_.title = this.getCurrentDirectory().replace(
3109 new RegExp('^' + RootDirectory.GDATA), 3112 new RegExp('^' + RootDirectory.GDATA),
3110 str('GDATA_DIRECTORY_LABEL')); 3113 str('GDATA_DIRECTORY_LABEL'));
3111 }, 3114 },
3112 3115
3113 /** 3116 /**
3114 * Updates search box value when directory gets changed. 3117 * Updates search box value when directory gets changed.
3115 */ 3118 */
3116 FileManager.prototype.updateSearchBoxOnDirChange_ = function() { 3119 FileManager.prototype.updateSearchBoxOnDirChange_ = function() {
3117 var searchBox = this.dialogDom_.querySelector('#search-box'); 3120 var searchBox = this.dialogDom_.querySelector('#search-box');
(...skipping 1103 matching lines...) Expand 10 before | Expand all | Expand 10 after
4221 } 4224 }
4222 4225
4223 var defaultActionSeparator = 4226 var defaultActionSeparator =
4224 this.dialogDom_.querySelector('#default-action-separator'); 4227 this.dialogDom_.querySelector('#default-action-separator');
4225 4228
4226 this.defaultActionMenuItem_.hidden = !taskItem; 4229 this.defaultActionMenuItem_.hidden = !taskItem;
4227 defaultActionSeparator.hidden = !taskItem; 4230 defaultActionSeparator.hidden = !taskItem;
4228 } 4231 }
4229 })(); 4232 })();
4230 4233
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698