chrome/test/data/extensions/api_test/webnavigation/test_getFrame.html - Issue 10835033: Only delete old frames when a new main frame navigation commits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webnavigation/test_getFrame.html

Issue 10835033: Only delete old frames when a new main frame navigation commits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('K') | « chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webnavigation/test_getFrame.html

diff --git a/chrome/test/data/extensions/api_test/webnavigation/test_getFrame.html b/chrome/test/data/extensions/api_test/webnavigation/test_getFrame.html

index 36ec7eb299b51662922bcf25d383e88a8861c2dc..70f35d84488771d16a20e366bb92caa1e2dc5555 100644

--- a/chrome/test/data/extensions/api_test/webnavigation/test_getFrame.html

+++ b/chrome/test/data/extensions/api_test/webnavigation/test_getFrame.html

@@ -8,7 +8,7 @@ chrome.test.runTests([

chrome.tabs.create({"url": "about:blank"}, function(tab) {

tabId = tab.id;

var done = chrome.test.listenForever(

- chrome.webNavigation.onBeforeNavigate,

+ chrome.webNavigation.onCommitted,

function (details) {

if (details.tabId != tabId)

return;