Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 10835033: Only delete old frames when a new main frame navigation commits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
index f88eeb19c914f049ebecd89f3cc9f7f69b5917df..85f95f1614135e792ed9c65b9876b7d4f7141c24 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h
@@ -40,6 +40,8 @@ class WebNavigationTabObserver : public content::NotificationObserver,
return navigation_state_;
}
+ content::RenderViewHost* render_view_host_in_process(int process_id) const;
Matt Perry 2012/07/30 11:52:43 should use CamelCase for non-inline functions.
jochen (gone - plz use gerrit) 2012/07/30 15:33:18 Done.
+
// content::NotificationObserver implementation.
virtual void Observe(int type,
const content::NotificationSource& source,
@@ -97,6 +99,12 @@ class WebNavigationTabObserver : public content::NotificationObserver,
bool IsReferenceFragmentNavigation(FrameNavigationState::FrameID frame_id,
const GURL& url);
+ // Creates and sends onErrorOccurred events for all on-going navigations. If
+ // |render_view_host| is non-NULL, only generates events for frames in this
+ // render view host.
+ void SendErrorEvents(content::WebContents* web_contents,
+ content::RenderViewHost* render_view_host);
+
// Tracks the state of the frames we are sending events for.
FrameNavigationState navigation_state_;

Powered by Google App Engine
This is Rietveld 408576698