base/critical_closure_stub.cc - Issue 10835032: Add APIs to protect critical tasks on iOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/critical_closure_stub.cc

Issue 10835032: Add APIs to protect critical tasks on iOS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address review comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/critical_closure.h"

	6

	7 namespace base {

	8

	9 base::Closure MakeCriticalClosure(const base::Closure& closure) {
	Mark Mentovai 2012/07/31 23:16:33 You should get rid of this stub file and write thi You should get rid of this stub file and write this code inline in the header for non-iOS. There should be to be zero code size impact on other platforms. stuartmorgan 2012/08/01 04:31:55 Okay; we did it this way originally because I thou Show quoted text On 2012/07/31 23:16:33, Mark Mentovai wrote: > You should get rid of this stub file and write this code inline in the header > for non-iOS. There should be to be zero code size impact on other platforms. Okay; we did it this way originally because I thought our style guide made non-header declarations preferred even for cases like this. I guess this falls under the "simple getter" case though (in a somewhat non-obvious way). Chen Yu 2012/08/01 11:26:13 Done. Show quoted text On 2012/08/01 04:31:55, stuartmorgan wrote: > On 2012/07/31 23:16:33, Mark Mentovai wrote: > > You should get rid of this stub file and write this code inline in the header > > for non-iOS. There should be to be zero code size impact on other platforms. > > Okay; we did it this way originally because I thought our style guide made > non-header declarations preferred even for cases like this. I guess this falls > under the "simple getter" case though (in a somewhat non-obvious way). Done.
	10 // No-op for platforms where the application does not need to acquire

	11 // background time for closures to finish when it goes into the background.

	12 return closure;

	13 }

	14

	15 } // namespace base

OLD	NEW

« base/critical_closure.h ('K') | « base/critical_closure_ios.mm ('k') | base/ios/scoped_critical_action.h » ('j') | base/ios/scoped_critical_action.h » ('J')