Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: base/memory/singleton.h

Issue 10835029: base: Suggest forward declare DefaultSingletonTraits in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/singleton.h
diff --git a/base/memory/singleton.h b/base/memory/singleton.h
index 4564790722b121fefcd19e4d0b6a587b108c46c0..0d4fc8990c443f3b025c37a5937bf232ca4ac14d 100644
--- a/base/memory/singleton.h
+++ b/base/memory/singleton.h
@@ -149,7 +149,7 @@ template <typename Type> base::subtle::Atomic32
// Example usage:
//
// In your header:
-// #include "base/memory/singleton.h"
+// template <typename T> struct DefaultSingletonTraits;
// class FooClass {
// public:
// static FooClass* GetInstance(); <-- See comment below on this.
@@ -162,6 +162,7 @@ template <typename Type> base::subtle::Atomic32
// };
//
// In your source file:
+// #include "base/memory/singleton.h"
// FooClass* FooClass::GetInstance() {
// return Singleton<FooClass>::get();
// }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698