Issue 10835029: base: Suggest forward declare DefaultSingletonTraits in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10835029: base: Suggest forward declare DefaultSingletonTraits in header files. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base: Suggest forward declare DefaultSingletonTraits in header files. Instead of including singleton.h in header files we can forward declare it, and include only in the source file. There is also a presubmit check for this, I didn't know ;) R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149095

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	base/memory/singleton.h	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10835029/1

8 years, 4 months ago (2012-07-30 18:19:13 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-07-30 18:19:15 UTC) #4

Presubmit check for 10835029-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template gets
instantiated in a single compilation unit.
  base/memory/singleton.h

Expand Messages | Collapse Messages