Refactor location bar content setting image GTK classes to

Refactor location bar content setting image GTK classes to
support web intents picker button.

R=bauerb@chromium.org
BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148826

[Bernhard Bauer, 2012-07-27 17:01:20]

LGTM with nits:

https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
File chrome/browser/ui/gtk/location_bar_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:167: virtual void
Update(TabContents* tab_contents) OVERRIDE;
Nit: Can you add a comment that these are PageToolViewGtk methods?

https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:169: virtual void
AnimationEnded(const ui::Animation* animation) OVERRIDE;
And maybe one here that this is an ui::AnimationDelegate method?

[Greg Billock, 2012-07-27 17:18:11]

https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
File chrome/browser/ui/gtk/location_bar_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:167: virtual void
Update(TabContents* tab_contents) OVERRIDE;
Oops! Yes, added.

On 2012/07/27 17:01:20, Bernhard Bauer wrote:
> Nit: Can you add a comment that these are PageToolViewGtk methods?

https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/location_bar_view_gtk.cc:169: virtual void
AnimationEnded(const ui::Animation* animation) OVERRIDE;
On 2012/07/27 17:01:20, Bernhard Bauer wrote:
> And maybe one here that this is an ui::AnimationDelegate method?

Done.

[Greg Billock, 2012-07-27 17:20:09]

On 2012/07/27 17:18:11, Greg Billock wrote:
>
https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
> File chrome/browser/ui/gtk/location_bar_view_gtk.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
> chrome/browser/ui/gtk/location_bar_view_gtk.cc:167: virtual void
> Update(TabContents* tab_contents) OVERRIDE;
> Oops! Yes, added.
> 
> On 2012/07/27 17:01:20, Bernhard Bauer wrote:
> > Nit: Can you add a comment that these are PageToolViewGtk methods?
> 
>
https://chromiumcodereview.appspot.com/10835020/diff/1/chrome/browser/ui/gtk/...
> chrome/browser/ui/gtk/location_bar_view_gtk.cc:169: virtual void
> AnimationEnded(const ui::Animation* animation) OVERRIDE;
> On 2012/07/27 17:01:20, Bernhard Bauer wrote:
> > And maybe one here that this is an ui::AnimationDelegate method?
> 
> Done.

erg or estade, can has owners lgtm?

[Elliot Glaysher, 2012-07-27 17:59:15]

gtk lgtm stamp

[commit-bot: I haz the power, 2012-07-27 18:07:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/10835020/3002

[commit-bot: I haz the power, 2012-07-27 19:05:37]

Try job failure for 10835020-3002 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-07-27 19:41:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gbillock@chromium.org/10835020/3004

[commit-bot: I haz the power, 2012-07-27 22:08:56]

Change committed as 148826