Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10835016: Rename media gallery -> media galleries in pref/UI components. (Closed)

Created:
8 years, 4 months ago by vandebo (ex-Chrome)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Rename media gallery -> media galleries in pref/UI components. Also rename registry to preferences. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -746 lines) Patch
A + chrome/browser/media_gallery/media_galleries_preferences.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/media_gallery/media_galleries_preferences.cc View 7 chunks +25 lines, -25 lines 0 comments Download
A chrome/browser/media_gallery/media_galleries_preferences_factory.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/media_gallery/media_galleries_preferences_factory.cc View 1 chunk +40 lines, -0 lines 0 comments Download
D chrome/browser/media_gallery/media_gallery_registry.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/media_gallery/media_gallery_registry.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/browser/media_gallery/media_gallery_registry_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/media_gallery/media_gallery_registry_factory.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/content_settings.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/options2/media_galleries_list.js View 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/resources/options2/media_galleries_manager_overlay.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/options2/media_galleries_manager_overlay.js View 4 chunks +8 lines, -8 lines 0 comments Download
D chrome/browser/resources/options2/media_gallery_list.js View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/resources/options2/media_gallery_manager_overlay.html View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/options2/media_gallery_manager_overlay.js View 1 chunk +0 lines, -82 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/options.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options2/media_galleries_handler.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/ui/webui/options2/media_galleries_handler.cc View 4 chunks +30 lines, -28 lines 0 comments Download
D chrome/browser/ui/webui/options2/media_gallery_handler.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/ui/webui/options2/media_gallery_handler.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vandebo (ex-Chrome)
8 years, 4 months ago (2012-07-27 00:55:24 UTC) #1
Evan Stade
lgtm thanks
8 years, 4 months ago (2012-07-27 03:08:15 UTC) #2
vandebo (ex-Chrome)
+erg for profile OWNERS approval
8 years, 4 months ago (2012-07-27 17:38:05 UTC) #3
Elliot Glaysher
profiles lgtm stamp
8 years, 4 months ago (2012-07-27 17:52:57 UTC) #4
vandebo (ex-Chrome)
+thestig for chrome OWNERS stamp
8 years, 4 months ago (2012-07-27 17:55:52 UTC) #5
Lei Zhang
LGTM Though it looks like you are moving files with git. You may end up ...
8 years, 4 months ago (2012-07-27 18:13:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10835016/1
8 years, 4 months ago (2012-07-27 18:16:57 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-27 21:14:29 UTC) #8 
Change committed as 148808

Powered by Google App Engine
This is Rietveld 408576698