Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 10835015: couple minor fixes to PageInfoBubble (Closed)

Created:
8 years, 5 months ago by Evan Stade
Modified:
8 years, 4 months ago
Reviewers:
Finnur, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

couple minor fixes to PageInfoBubble 1450 is too long for an animation. In this case it is painfully long. BUG=none TEST=clicking on the page icon on https://google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/views/page_info_bubble_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
8 years, 5 months ago (2012-07-26 23:48:25 UTC) #1
Finnur
LGTM (late reply as I was travelling on Fri).
8 years, 4 months ago (2012-07-29 18:57:49 UTC) #2
Evan Stade
On 2012/07/29 18:57:49, Finnur wrote: > LGTM (late reply as I was travelling on Fri). ...
8 years, 4 months ago (2012-07-30 19:00:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10835015/1
8 years, 4 months ago (2012-07-30 19:01:05 UTC) #4
commit-bot: I haz the power
Presubmit check for 10835015-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 19:01:08 UTC) #5
Evan Stade
Scott for OWNER
8 years, 4 months ago (2012-08-02 00:54:22 UTC) #6
sky
LGTM
8 years, 4 months ago (2012-08-02 16:21:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10835015/1
8 years, 4 months ago (2012-08-02 16:31:22 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 18:18:11 UTC) #9
Change committed as 149655

Powered by Google App Engine
This is Rietveld 408576698