Issue 10835014: Support copying a partial rectangle region from the compositing surface on Mac.

Issue 10835014: Support copying a partial rectangle region from the compositing surface on Mac. (Closed)

Created:
8 years, 5 months ago by mazda

Modified:
8 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Support copying a partial rectangle region from the compositing surface on Mac. This CL also made RenderWidgetHostView::MacCopyFromCompositingSurface support HiDPI. BUG=118571 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148690

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -22 lines)			Patch
M	content/browser/renderer_host/compositing_iosurface_mac.h	View	1	5 chunks	+23 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/compositing_iosurface_mac.mm	View	1	6 chunks	+13 lines, -7 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm with nits http://codereview.chromium.org/10835014/diff/1/content/browser/renderer_host/compositing_iosurface_mac.mm File content/browser/renderer_host/compositing_iosurface_mac.mm (right): http://codereview.chromium.org/10835014/diff/1/content/browser/renderer_host/compositing_iosurface_mac.mm#newcode309 content/browser/renderer_host/compositing_iosurface_mac.mm:309: const gfx::Size& dst_size, Can you call ...

8 years, 5 months ago (2012-07-26 23:45:48 UTC) #2

mazda

Thank you for the quick response. I addressed the comments. http://codereview.chromium.org/10835014/diff/1/content/browser/renderer_host/compositing_iosurface_mac.mm File content/browser/renderer_host/compositing_iosurface_mac.mm (right): http://codereview.chromium.org/10835014/diff/1/content/browser/renderer_host/compositing_iosurface_mac.mm#newcode309 ...

8 years, 5 months ago (2012-07-27 00:00:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10835014/5001

8 years, 5 months ago (2012-07-27 00:02:40 UTC) #4

Change committed as 148690

Expand Messages | Collapse Messages