Issue 10835003: Revise IBusEngineService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10835003: Revise IBusEngineService. (Closed)

Created:
8 years, 4 months ago by Seigo Nonaka

Modified:
8 years, 4 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revise IBusEngineService. This CL contains - Make ProcessKeyEvent asynchronous and add unittest for asynchronous handling. - Add missing signal (CommitText). - Fix wrong signal name (UpdatePreedit -> UpdatePreeditText). BUG=None TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148725

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -8 lines)			Patch
M	chromeos/dbus/ibus/ibus_constants.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service.h	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service.cc	View	3 chunks	+22 lines, -2 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service_unittest.cc	View	4 chunks	+93 lines, -4 lines	0 comments	Download
M	chromeos/dbus/ibus/mock_ibus_engine_service.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10835003/1

8 years, 4 months ago (2012-07-26 15:54:26 UTC) #3

commit-bot: I haz the power

Try job failure for 10835003-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-07-26 16:18:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10835003/1

8 years, 4 months ago (2012-07-27 04:21:56 UTC) #5

Change committed as 148725

Expand Messages | Collapse Messages