Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10834431: third_party/protobuf should build on the x86_64 architecture (Closed)

Created:
8 years, 4 months ago by Cătălin Badea
Modified:
8 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Mihai Maerean
Visibility:
Public.

Description

third_party/protobuf should build on the x86_64 architecture. BUG=143907

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use mac os X specific macro. #

Total comments: 1

Patch Set 3 : Add appropriate comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/protobuf/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/atomicops.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Cătălin Badea
Please review this patch.
8 years, 4 months ago (2012-08-21 14:59:17 UTC) #1
Mark Mentovai
https://chromiumcodereview.appspot.com/10834431/diff/1/third_party/protobuf/src/google/protobuf/stubs/atomicops.h File third_party/protobuf/src/google/protobuf/stubs/atomicops.h (left): https://chromiumcodereview.appspot.com/10834431/diff/1/third_party/protobuf/src/google/protobuf/stubs/atomicops.h#oldcode74 third_party/protobuf/src/google/protobuf/stubs/atomicops.h:74: typedef intptr_t Atomic64; You are changing this for all ...
8 years, 4 months ago (2012-08-21 15:22:04 UTC) #2
Cătălin Badea
I have uploaded a new patch set. The changes now affect only 64-bit mac builds. ...
8 years, 4 months ago (2012-08-22 11:23:48 UTC) #3
Mark Mentovai
If you can get this fixed in the upstream first, that would absolutely be preferable. ...
8 years, 4 months ago (2012-08-22 13:11:26 UTC) #4
Cătălin Badea
I've added comments and I will post the patch on protobuf's project page.
8 years, 4 months ago (2012-08-23 09:22:41 UTC) #5
Cătălin Badea
I opened an issue with this patch on protobuf's project page. They have yet to ...
8 years, 4 months ago (2012-08-24 15:12:26 UTC) #6
Cătălin Badea
On 2012/08/24 15:12:26, Catalin Badea wrote: > I opened an issue with this patch on ...
8 years, 3 months ago (2012-08-30 09:20:12 UTC) #7
Mark Mentovai
Have you brought it up on the protobuf mailing list/discussion group? http://groups.google.com/group/protobuf On Thu, Aug ...
8 years, 3 months ago (2012-08-30 21:39:36 UTC) #8
Mark Mentovai
Have you brought it up on the protobuf mailing list/discussion group? http://groups.google.com/group/protobuf On Thu, Aug ...
8 years, 3 months ago (2012-08-30 21:39:36 UTC) #9
Mark Mentovai
Ah, I see you have. I’d run “svn log http://protobuf.googlecode.com/svn/trunk/src/google/protobuf/stubs/atomicops.h” and write to the person ...
8 years, 3 months ago (2012-08-30 21:42:51 UTC) #10
Mark Mentovai
8 years, 3 months ago (2012-08-30 21:42:51 UTC) #11
Ah, I see you have.

I’d run “svn log
http://protobuf.googlecode.com/svn/trunk/src/google/protobuf/stubs/atomicops.h”
and write to the person that appears to be the responsible party. Looks
like the file’s had recent activity, so that ought to do it.


On Thu, Aug 30, 2012 at 5:39 PM, Mark Mentovai <mark@chromium.org> wrote:

> Have you brought it up on the protobuf mailing list/discussion group?
>
> http://groups.google.com/group/protobuf
>
>
> On Thu, Aug 30, 2012 at 5:20 AM, <badea@adobe.com> wrote:
>
>> On 2012/08/24 15:12:26, Catalin Badea wrote:
>>
>>> I opened an issue with this patch on protobuf's project page. They have
>>> yet to
>>> respond.
>>> link:
http://code.google.com/p/**protobuf/issues/detail?id=412<http://code.google.c...
>>>
>>
>> I didn't get any feedback from the protobuf maintainers. They're google
>> group
>> doesn't seem very active either. Could you help me ping the right people,
>> please?
>>
>>
>>
>>
https://chromiumcodereview.**appspot.com/10834431/<https://chromiumcodereview...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698