Re-enable Ctrl-w and Ctrl-Shift-w when a non-Pepper window is maximized

Re-enable Ctrl-w and Ctrl-Shift-w when a non-Pepper window is maximized.

This is a temporary fix for M22 for crbug.com/143442, and should be reverted on trunk as part of crbug.com/142422. This CL is basically a second trial of r151121 which was also a temporary fix for M22.  r151121 disabled Ctrl-w and Ctrl-Shift-w when any kind of full screen window was active, but it turned out that the limitation was too strict; we should not disable Ctrl-w and Ctrl-Shift-w when a non-Pepper window was maximized.

BUG=143442, 142422
TEST=confirmed that C-w/C-S-w do not crash when a browser window is maximized.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153206

[Yusuke Sato, 2012-08-20 23:24:19]

Stefan, could you have a look at this?

[Mr4D (OOO till 08-26), 2012-08-21 00:17:14]

As discussed. I am fine with the change as long as you have tested that YouTube
full screen does not crash when closing with Ctrl+W.

Many thanks for looking into this!

[Mr4D (OOO till 08-26), 2012-08-21 00:17:34]

lgtm

http://codereview.chromium.org/10834421/diff/1/chrome/browser/ui/browser_comm...
File chrome/browser/ui/browser_command_controller.cc (right):

http://codereview.chromium.org/10834421/diff/1/chrome/browser/ui/browser_comm...
chrome/browser/ui/browser_command_controller.cc:1109: !window()->IsFullscreen();
Please check that this does not crash with playing YouTube videos in full
screen.

[Yusuke Sato, 2012-08-21 00:28:23]

http://codereview.chromium.org/10834421/diff/1/chrome/browser/ui/browser_comm...
File chrome/browser/ui/browser_command_controller.cc (right):

http://codereview.chromium.org/10834421/diff/1/chrome/browser/ui/browser_comm...
chrome/browser/ui/browser_command_controller.cc:1109: !window()->IsFullscreen();
On 2012/08/21 00:17:34, Mr4D wrote:
> Please check that this does not crash with playing YouTube videos in full
> screen. 

Thanks for the review. I've confirmed that pressing C-w/C-S-w on full-screen
Pepper YT does not crash Chrome.

[Yusuke Sato, 2012-08-21 00:28:53]

Ben, could you do an OWNERS review?

[Yusuke Sato, 2012-08-22 15:37:27]

Ben, could you review this? This is for M22 stable blocker.

[Ben Goodger (Google), 2012-08-22 16:06:03]

lgtm, note that this function was removed on trunk so you'll have to apply it to
the branch.