Issue 10834408: While allocating code objects, perform the incremental marking step before NULLing the new object. …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834408: While allocating code objects, perform the incremental marking step before NULLing the new object. … (Closed)

Created:
8 years, 4 months ago by Toon Verwaest

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

While allocating code objects, perform the incremental marking step before NULLing the new object. Otherwise the code cache cannot iterate the code space anymore, which is required to clear ICs. Committed: https://code.google.com/p/v8/source/detail?r=12345

Patch Set 1 #

Patch Set 2 : Zap code with magic constant. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/spaces.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
	M	src/v8globals.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages