Issue 10834405: Fix test failures introduced by r12342.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834405: Fix test failures introduced by r12342. (Closed)

Created:
8 years, 4 months ago by ulan

Modified:
8 years, 4 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix test failures introduced by r12342. Add missing context disposed notifications in test-api. Move send-idle-notification flag to d8 options so that it is available in d8 when v8 is build as a shared libarary. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12343

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -6 lines)			Patch
M	src/d8.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/d8.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/08/20 13:10:13, ulan wrote:
> PTAL

LGTM.

Expand Messages | Collapse Messages