Make sure events for browser actions, page actions and script badges are not delivered twice.

Make sure events for browser actions, page actions and script badges are not delivered twice. 

BUG=124873
TEST=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152310

[Finnur, 2012-08-17 14:45:29]

Annotated with explanations of the fixes I made.

https://chromiumcodereview.appspot.com/10834393/diff/1/chrome/browser/ui/gtk/...
File chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc
(left):

https://chromiumcodereview.appspot.com/10834393/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc:67: }
The bug I'm fixing is that if the extension has no named commands, this function
will not do anything further. This is incorrect, as extensions can have browser
actions and no named commands. Therefore, we should not abort when this function
returns false.

https://chromiumcodereview.appspot.com/10834393/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc:148:
event_targets_.erase(old);
When reviewing this code more closely (following the discovery of the bug above)
I realized we should delete all related event targets when a keybinding is
removed, not just the ones we registered. This fixes that as well.

https://chromiumcodereview.appspot.com/10834393/diff/1/chrome/browser/ui/gtk/...
File chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc
(right):

https://chromiumcodereview.appspot.com/10834393/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc:124: //
Add the Script Badge (if any).
Script Badge support was recently added. Therefore we need to keep track of
those too.

[Elliot Glaysher, 2012-08-17 16:27:32]

lgtm