Issue 10834386: Cleanup Blob code dependency

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834386: Cleanup Blob code dependency (Closed)

Created:
8 years, 4 months ago by kinuko

Modified:
8 years, 4 months ago

Reviewers:
tony, Dirk Pranke

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleanup Blob code dependency Removing BlobData::BlobData(const WebBlobData&), and instead adding new NewBlobData(const WebBlobData&) method only for test_shell. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152497

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -64 lines)			Patch
M	webkit/blob/blob_data.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/blob/blob_data.cc	View	2 chunks	+0 lines, -62 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_webblobregistry_impl.cc	View	3 chunks	+42 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dirk Pranke

Nice. lgtm. Also cc'ing Darin because I believe he was doing something with WebStringToFilePathString recently.

8 years, 4 months ago (2012-08-17 18:12:45 UTC) #2

test_shell LGTM.