Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10834384: Add AssertIOAllowed check in the SysInfo::AmountOfFreeDiskSpace. (Closed)

Created:
8 years, 4 months ago by Haruki Sato
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add AssertIOAllowed check in the implementations of SysInfo::AmountOfFreeDiskSpace. BUG=143335 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/sys_info_posix.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M base/sys_info_win.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Haruki Sato
8 years, 4 months ago (2012-08-17 07:36:36 UTC) #1
jar (doing other things)
This seems, at first glance, like the wrong fix. Can you justify why you want ...
8 years, 4 months ago (2012-08-18 01:13:31 UTC) #2
Haruki Sato
On 2012/08/18 01:13:31, jar wrote: > This seems, at first glance, like the wrong fix. ...
8 years, 4 months ago (2012-08-20 20:43:16 UTC) #3
satorux1
jar@, I guess there was some misunderstanding. As of now, AmountOfFreeDiskSpace() can be called from ...
8 years, 4 months ago (2012-08-20 21:32:45 UTC) #4
jar (doing other things)
LGTM I misread it originally.
8 years, 4 months ago (2012-08-21 02:24:35 UTC) #5
Haruki Sato
On 2012/08/21 02:24:35, jar wrote: > LGTM > > I misread it originally. thank you ...
8 years, 4 months ago (2012-08-21 16:42:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/10834384/1
8 years, 4 months ago (2012-08-21 16:42:49 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 19:50:05 UTC) #8
Change committed as 152612

Powered by Google App Engine
This is Rietveld 408576698