Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: net/base/mime_util_unittest.cc

Issue 10834383: Chrome OS "open with" picker allowing Web Intents (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed mime matching code, asserts that the mime-pattern "*" matches a blank mime-type (i.e. "*" mat… Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/mime_util_unittest.cc
diff --git a/net/base/mime_util_unittest.cc b/net/base/mime_util_unittest.cc
index 8210b0c9d954d9d9f3f7d14c6a774093abd2ac6e..af214332cf2ef5bf029bc2c170f73117b799a06d 100644
--- a/net/base/mime_util_unittest.cc
+++ b/net/base/mime_util_unittest.cc
@@ -80,6 +80,7 @@ TEST(MimeUtilTest, LookupTypes) {
TEST(MimeUtilTest, MatchesMimeType) {
EXPECT_TRUE(MatchesMimeType("*", "video/x-mpeg"));
+ EXPECT_TRUE(MatchesMimeType("*", ""));
benwells 2012/08/27 08:02:59 Is there a reason to add this test?
thorogood 2012/08/28 00:04:04 The reason for this is that it demonstrates that i
EXPECT_TRUE(MatchesMimeType("video/*", "video/x-mpeg"));
EXPECT_TRUE(MatchesMimeType("video/x-mpeg", "video/x-mpeg"));
EXPECT_TRUE(MatchesMimeType("application/*+xml",

Powered by Google App Engine
This is Rietveld 408576698