Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10834378: Upstream Android-specific tweaks to neterror.html. (Closed)

Created:
8 years, 4 months ago by newt (away)
Modified:
8 years, 4 months ago
Reviewers:
Nico, eroman
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Upstream Android-specific tweaks to neterror.html. BUG=136951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/renderer/resources/neterror.html View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
newt (away)
PTAL, thanks!
8 years, 4 months ago (2012-08-17 01:29:48 UTC) #1
Nico
eroman, did you do the neterror ui?
8 years, 4 months ago (2012-08-17 02:56:46 UTC) #2
eroman
No I didn't however either me or mmenke can review this. Matt, do you want ...
8 years, 4 months ago (2012-08-20 18:38:06 UTC) #3
mmenke
Happy to. LGTM. On 2012/08/20 18:38:06, eroman wrote: > No I didn't however either me ...
8 years, 4 months ago (2012-08-20 18:45:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10834378/1
8 years, 4 months ago (2012-08-20 18:50:42 UTC) #5
commit-bot: I haz the power
Presubmit check for 10834378-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-20 18:50:47 UTC) #6
newt (away)
On 2012/08/20 18:50:47, I haz the power (commit-bot) wrote: > Presubmit check for 10834378-1 failed ...
8 years, 4 months ago (2012-08-20 20:28:29 UTC) #7
Nico
lgtm
8 years, 4 months ago (2012-08-20 20:28:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10834378/1
8 years, 4 months ago (2012-08-20 20:43:19 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 23:57:57 UTC) #10
Change committed as 152435

Powered by Google App Engine
This is Rietveld 408576698