Introduce InternalProperty type and expose internal properties for bound functions

Introduce InternalProperty type and expose internal properties for bound functions

Committed: https://code.google.com/p/v8/source/detail?r=12346

Committed: https://code.google.com/p/v8/source/detail?r=12477

[Peter Rybin, 2012-08-17 01:33:38]

This change introduces InternalPropertyMirror -- a class that helps to expose
such inner values as [[BoundThis]] or [[PrimitiveValue]] from the spec.

The regular PropertyMirror class is (arguably) too heavyweight for this, for
example because it requires reference to parent mirror.

Previous handing of internalProperty is discarded.

[Yang, 2012-08-17 11:20:37]

On 2012/08/17 01:33:38, Peter Rybin wrote:
> This change introduces InternalPropertyMirror -- a class that helps to expose
> such inner values as [[BoundThis]] or [[PrimitiveValue]] from the spec.
> 
> The regular PropertyMirror class is (arguably) too heavyweight for this, for
> example because it requires reference to parent mirror.
> 
> Previous handing of internalProperty is discarded.

Some minor comments. I think a test case makes sense here.

[Yang, 2012-08-17 11:20:44]

http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js
File src/mirror-debugger.js (right):

http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js#newc...
src/mirror-debugger.js:2268: throw new Error('PropertyMirror cannot be
serialized independeltly');
"independently"

http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js#newc...
src/mirror-debugger.js:2344: *    "properties":[<properties>]}
update comment

[Peter Rybin, 2012-08-17 23:13:09]

http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js
File src/mirror-debugger.js (right):

http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js#newc...
src/mirror-debugger.js:2268: throw new Error('PropertyMirror cannot be
serialized independeltly');
On 2012/08/17 11:20:44, Yang wrote:
> "independently"

Done.

http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js#newc...
src/mirror-debugger.js:2344: *    "properties":[<properties>]}
On 2012/08/17 11:20:44, Yang wrote:
> update comment

Done.

[Yang, 2012-08-20 07:17:39]

On 2012/08/17 23:13:09, Peter Rybin wrote:
> http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js
> File src/mirror-debugger.js (right):
> 
>
http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js#newc...
> src/mirror-debugger.js:2268: throw new Error('PropertyMirror cannot be
> serialized independeltly');
> On 2012/08/17 11:20:44, Yang wrote:
> > "independently"
> 
> Done.
> 
>
http://codereview.chromium.org/10834376/diff/2001/src/mirror-debugger.js#newc...
> src/mirror-debugger.js:2344: *    "properties":[<properties>]}
> On 2012/08/17 11:20:44, Yang wrote:
> > update comment
> 
> Done.

LGTM.

[Peter Rybin, 2012-09-01 21:23:21]

The change causes a crash on mirror-object.js on ARM-simulator/Release.

See http://code.google.com/p/v8/issues/detail?id=2314

[Peter Rybin, 2012-09-01 21:34:21]

Yang,

I believe I fairly addressed the crash on ARM that caused the rollback of this
change (see the bug in previous message).

Let's commit it again with either --nocrankshaft or skip on ARM. Which one would
you prefer?