Add a field to ClassNode that holds a NodeList of its members.

tests/compiler/dart2js/unparser2_test.dart

Index: tests/compiler/dart2js/unparser2_test.dart
===================================================================
--- tests/compiler/dart2js/unparser2_test.dart	(revision 0)
+++ tests/compiler/dart2js/unparser2_test.dart	(revision 0)
@@ -0,0 +1,132 @@
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#import("../../../lib/compiler/implementation/scanner/scannerlib.dart");

[Anton Muhin, 2012/08/21 16:51:32]

why a new test?  cannot it go into unparser?

[messick, 2012/08/21 17:42:01]

Peter and I discussed this earlier in the review cycle.

+#import("../../../lib/compiler/implementation/elements/elements.dart"); // only need CompilationUnitElement
+#import("../../../lib/compiler/implementation/tree/tree.dart");
+#import("../../../lib/compiler/implementation/leg.dart"); // only need DiagnosticListener & Script
+
+main() {
+  testClassDef();
+  testClass1Field();
+  testClass2Fields();
+  testClass1Field1Method();
+  testClass1Field2Method();
+  testClassDefTypeParam();
+}
+
+testClassDef() {

[Anton Muhin, 2012/08/21 16:51:32]

up to you, but I would rather assert the strings like class T{} come unchanged
when unparsed.

[messick, 2012/08/21 17:42:01]

At a minimum, it will have a space after the class name. I'm happy to make this
example look however most people expect it to look.

+  compareCode('''
+      class T{}
+      ''', '''
+      class T {
+      }
+      ''');
+}
+
+testClass1Field() {
+  compareCode('''
+      class T{var x;}
+      ''', '''
+      class T {
+        var x;
+      }
+  ''');
+}
+
+testClass2Fields() {
+  compareCode('''
+      class T{var x; var y;}
+      ''', '''
+      class T {
+        var x;
+        var y;
+      }
+  ''');
+}
+
+testClass1Field1Method() {
+  compareCode('''
+      class T{var x;m(){}}
+      ''', '''
+      class T {
+        var x;
+        m(){}
+      }
+  ''');
+}
+
+testClass1Field2Method() {
+  compareCode('''
+      class T{a(){}b(){}}
+      ''', '''
+      class T {
+        a(){}
+        b(){}
+      }
+  ''');
+}
+
+testClassDefTypeParam() {
+  compareCode('''
+      class T<X>{}
+      ''', '''
+      class T<X> {
+      }
+      ''');
+}
+
+void compareCode(String original, String expected) {
+  String unparsed = doUnparse(cleanUpLiteral(original));
+  Expect.equals(cleanUpLiteral(expected), unparsed);
+}
+
+String cleanUpLiteral(String text) {
+  var lines = text.split('\n');
+  for (var j = 0; j < lines.length; j++) {
+    if (lines[j].length > 6) {

[Anton Muhin, 2012/08/21 16:51:32]

that looks somewhat fragile to encode a constant like 6

[messick, 2012/08/21 17:42:01]

OK, I'll define a constant. I didn't bother because this is test code, but it
would make it more readable.

+      lines[j] = lines[j].substring(6, lines[j].length);
+    } else {
+      lines[j] = '';
+    }
+  }
+  return Strings.join(lines, '\n');
+}
+
+String doUnparse(String source) {
+  MessageCollector diagnosticListener = new MessageCollector();
+  Script script = new Script(null, null);
+  LibraryElement lib = new LibraryElement(script);
+  CompilationUnitElement element = new CompilationUnitElement(script, lib);
+  StringScanner scanner = new StringScanner(source);
+  Token beginToken = scanner.tokenize();
+  NodeListener listener = new NodeListener(diagnosticListener, element);
+  Parser parser = new Parser(listener);
+  parser.parseUnit(beginToken);
+  Node node = listener.popNode();
+  Expect.isTrue(listener.nodes.isEmpty());
+  return new Unparser().unparse(node);
+}
+
+class MessageCollector implements DiagnosticListener {
+  List<String> messages;
+  MessageCollector() {
+    messages = [];
+  }
+  void cancel([String reason, node, token, instruction, element]) {
+    messages.add(reason);
+    throw reason;
+  }
+  void log(message) {
+    messages.add(message);
+  }
+  void internalErrorOnElement(Element element, String message) {
+    throw message;
+  }
+  void internalError(String message,
+                     [Node node, Token token, Dynamic instruction,
+                      Element element]) {
+    throw message;
+  }
+}