Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: chrome/browser/ui/omnibox/omnibox_edit_unittest.cc

Issue 10834368: Convert mostly favicon related code from SkBitmap to ImageSkia and Image (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/utf_string_conversions.h" 5 #include "base/utf_string_conversions.h"
6 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h" 6 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
7 #include "chrome/browser/search_engines/template_url_service_factory.h" 7 #include "chrome/browser/search_engines/template_url_service_factory.h"
8 #include "chrome/browser/ui/omnibox/omnibox_edit_controller.h" 8 #include "chrome/browser/ui/omnibox/omnibox_edit_controller.h"
9 #include "chrome/browser/ui/omnibox/omnibox_edit_model.h" 9 #include "chrome/browser/ui/omnibox/omnibox_edit_model.h"
10 #include "chrome/browser/ui/omnibox/omnibox_view.h" 10 #include "chrome/browser/ui/omnibox/omnibox_view.h"
11 #include "chrome/test/base/testing_browser_process.h" 11 #include "chrome/test/base/testing_browser_process.h"
12 #include "chrome/test/base/testing_profile.h" 12 #include "chrome/test/base/testing_profile.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "third_party/skia/include/core/SkBitmap.h"
15 #include "ui/gfx/font.h" 14 #include "ui/gfx/font.h"
15 #include "ui/gfx/image/image.h"
16 16
17 using content::WebContents; 17 using content::WebContents;
18 18
19 namespace { 19 namespace {
20 20
21 class TestingOmniboxView : public OmniboxView { 21 class TestingOmniboxView : public OmniboxView {
22 public: 22 public:
23 TestingOmniboxView() : OmniboxView(NULL, NULL, NULL, NULL) {} 23 TestingOmniboxView() : OmniboxView(NULL, NULL, NULL, NULL) {}
24 24
25 virtual void SaveStateToTab(WebContents* tab) OVERRIDE {} 25 virtual void SaveStateToTab(WebContents* tab) OVERRIDE {}
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 TestingOmniboxEditController() {} 88 TestingOmniboxEditController() {}
89 virtual void OnAutocompleteAccept(const GURL& url, 89 virtual void OnAutocompleteAccept(const GURL& url,
90 WindowOpenDisposition disposition, 90 WindowOpenDisposition disposition,
91 content::PageTransition transition, 91 content::PageTransition transition,
92 const GURL& alternate_nav_url) OVERRIDE {} 92 const GURL& alternate_nav_url) OVERRIDE {}
93 virtual void OnChanged() OVERRIDE {} 93 virtual void OnChanged() OVERRIDE {}
94 virtual void OnSelectionBoundsChanged() OVERRIDE {} 94 virtual void OnSelectionBoundsChanged() OVERRIDE {}
95 virtual void OnInputInProgress(bool in_progress) OVERRIDE {} 95 virtual void OnInputInProgress(bool in_progress) OVERRIDE {}
96 virtual void OnKillFocus() OVERRIDE {} 96 virtual void OnKillFocus() OVERRIDE {}
97 virtual void OnSetFocus() OVERRIDE {} 97 virtual void OnSetFocus() OVERRIDE {}
98 virtual SkBitmap GetFavicon() const OVERRIDE { return SkBitmap(); } 98 virtual gfx::Image GetFavicon() const OVERRIDE { return gfx::Image(); }
99 virtual string16 GetTitle() const OVERRIDE { return string16(); } 99 virtual string16 GetTitle() const OVERRIDE { return string16(); }
100 virtual InstantController* GetInstant() OVERRIDE { return NULL; } 100 virtual InstantController* GetInstant() OVERRIDE { return NULL; }
101 virtual TabContents* GetTabContents() const OVERRIDE { 101 virtual TabContents* GetTabContents() const OVERRIDE {
102 return NULL; 102 return NULL;
103 } 103 }
104 104
105 private: 105 private:
106 DISALLOW_COPY_AND_ASSIGN(TestingOmniboxEditController); 106 DISALLOW_COPY_AND_ASSIGN(TestingOmniboxEditController);
107 }; 107 };
108 108
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 GURL url; 174 GURL url;
175 bool write_url; 175 bool write_url;
176 model.AdjustTextForCopy(input[i].sel_start, input[i].is_all_selected, 176 model.AdjustTextForCopy(input[i].sel_start, input[i].is_all_selected,
177 &result, &url, &write_url); 177 &result, &url, &write_url);
178 EXPECT_EQ(ASCIIToUTF16(input[i].expected_output), result) << "@: " << i; 178 EXPECT_EQ(ASCIIToUTF16(input[i].expected_output), result) << "@: " << i;
179 EXPECT_EQ(input[i].write_url, write_url) << " @" << i; 179 EXPECT_EQ(input[i].write_url, write_url) << " @" << i;
180 if (write_url) 180 if (write_url)
181 EXPECT_EQ(input[i].expected_url, url.spec()) << " @" << i; 181 EXPECT_EQ(input[i].expected_url, url.spec()) << " @" << i;
182 } 182 }
183 } 183 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698