Get 'all_unittests' and 'test_suite' building for iOS.

Get 'all_unittests' and 'test_suite' building for iOS.

BUG=None.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152411

[Nico, 2012-08-16 17:32:58]

lgtm

No tracking bug?

https://chromiumcodereview.appspot.com/10834364/diff/1/ui/test/test_suite.cc
File ui/test/test_suite.cc (right):

https://chromiumcodereview.appspot.com/10834364/diff/1/ui/test/test_suite.cc#...
ui/test/test_suite.cc:44: base::mac::SetOverrideFrameworkBundlePath(path);
Out of interest, how do yo guys handle resource loading in tests in chrome/ios?

https://chromiumcodereview.appspot.com/10834364/diff/1/ui/test/test_suite.cc#...
ui/test/test_suite.cc:54: #endif  // defined(OS_MACOSX)
update this

[justincohen, 2012-08-20 20:07:25]

Rohit, can you answer Nico's question about resource loading in tests?

https://chromiumcodereview.appspot.com/10834364/diff/1/ui/test/test_suite.cc
File ui/test/test_suite.cc (right):

https://chromiumcodereview.appspot.com/10834364/diff/1/ui/test/test_suite.cc#...
ui/test/test_suite.cc:44: base::mac::SetOverrideFrameworkBundlePath(path);
I vaguely understand this, but I'll ask Rohit to comment

On 2012/08/16 17:32:58, Nico wrote:
> Out of interest, how do yo guys handle resource loading in tests in
chrome/ios?

https://chromiumcodereview.appspot.com/10834364/diff/1/ui/test/test_suite.cc#...
ui/test/test_suite.cc:54: #endif  // defined(OS_MACOSX)
On 2012/08/16 17:32:58, Nico wrote:
> update this

Done.

[commit-bot: I haz the power, 2012-08-20 20:08:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@chromium.org/10834364/3001

[rohitrao (ping after 24h), 2012-08-20 20:29:45]

> No tracking bug?

We decided against filing one-off crbugs for each upstreaming CL (or putting a
single catch-all crbug for all upstreaming CLs).

> Out of interest, how do yo guys handle resource loading in tests in
chrome/ios?

We've switched to a model where we have a .gypi that declares all of the
resources we need, and we include that in all of the top-level targets.

We originally followed the mac model and copied Chrome.app into the unit_test
bundle.  I forget all the various problems we had, but in the end it became
mostly unworkable.

[commit-bot: I haz the power, 2012-08-20 22:27:19]

Change committed as 152411