Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10834362: Support for iOS in OCMock (Closed)

Created:
8 years, 4 months ago by justincohen
Modified:
8 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Support for iOS in OCMock Added ifdefs around NSRect, added iOS to gyp. BUG=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151989

Patch Set 1 #

Total comments: 5

Patch Set 2 : Remove extra line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/ocmock/ocmock.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ocmock/ocmock_extensions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/ocmock/ocmock_extensions.mm View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
justincohen
8 years, 4 months ago (2012-08-16 15:52:43 UTC) #1
Robert Sesek
https://chromiumcodereview.appspot.com/10834362/diff/1/third_party/ocmock/ocmock_extensions.h File third_party/ocmock/ocmock_extensions.h (right): https://chromiumcodereview.appspot.com/10834362/diff/1/third_party/ocmock/ocmock_extensions.h#newcode32 third_party/ocmock/ocmock_extensions.h:32: #if !TARGET_OS_IPHONE Why TARGET_OS_IPHONE instead of defined(OS_IOS)? https://chromiumcodereview.appspot.com/10834362/diff/1/third_party/ocmock/ocmock_extensions.mm File ...
8 years, 4 months ago (2012-08-16 15:53:58 UTC) #2
justincohen
PTAL https://chromiumcodereview.appspot.com/10834362/diff/1/third_party/ocmock/ocmock_extensions.h File third_party/ocmock/ocmock_extensions.h (right): https://chromiumcodereview.appspot.com/10834362/diff/1/third_party/ocmock/ocmock_extensions.h#newcode32 third_party/ocmock/ocmock_extensions.h:32: #if !TARGET_OS_IPHONE If this goes all the way ...
8 years, 4 months ago (2012-08-16 16:17:54 UTC) #3
Robert Sesek
LGTM https://chromiumcodereview.appspot.com/10834362/diff/1/third_party/ocmock/ocmock_extensions.h File third_party/ocmock/ocmock_extensions.h (right): https://chromiumcodereview.appspot.com/10834362/diff/1/third_party/ocmock/ocmock_extensions.h#newcode32 third_party/ocmock/ocmock_extensions.h:32: #if !TARGET_OS_IPHONE On 2012/08/16 16:17:54, justincohen wrote: > ...
8 years, 4 months ago (2012-08-16 16:20:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/10834362/3002
8 years, 4 months ago (2012-08-16 16:26:55 UTC) #5
commit-bot: I haz the power
Try job failure for 10834362-3002 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-16 18:07:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/10834362/3002
8 years, 4 months ago (2012-08-16 18:13:58 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 00:02:58 UTC) #8 
Change committed as 151989

Powered by Google App Engine
This is Rietveld 408576698