Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 10834359: dart2dart Fix setter ref with library prefix. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/unparser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/dart_backend/placeholder_collector.dart
diff --git a/lib/compiler/implementation/dart_backend/placeholder_collector.dart b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
index 84a5e5b2160e479d25d8be15f549f9eefd3ea5dd..07100a5322c4835157a2a4f1dad5436c85aec7b8 100644
--- a/lib/compiler/implementation/dart_backend/placeholder_collector.dart
+++ b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
@@ -40,7 +40,11 @@ class SendVisitor extends ResolvedVisitor {
}
// We don't want to rename non top-level element access
// unless it's a local variable.
- if (!element.isTopLevel()) {
+ if (element.isPrefix()) {
+ // Node is prefix part in case of source 'lib.somesetter = 5;'
+ collector.makeNullPlaceholder(node);
+ return;
+ } else if (!element.isTopLevel()) {
// May get FunctionExpression here in selector
// in case of A(int this.f());
if (node.selector is Identifier) {
« no previous file with comments | « no previous file | tests/compiler/dart2js/unparser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698