Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 10834355: Enable verbose logging during PluginMsg_CreateInstance. (Closed)

Created:
8 years, 4 months ago by Bernhard Bauer
Modified:
8 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Enable verbose logging during PluginMsg_CreateInstance. This should get rid of the spurious ERROR messages when closing tabs, and log backtraces when we need them. BUG=141055 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151975 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152395

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : review #

Patch Set 4 : fix crashes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M content/common/np_channel_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 2 3 4 chunks +34 lines, -6 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Bernhard Bauer
Please review. Thanks!
8 years, 4 months ago (2012-08-16 16:00:23 UTC) #1
piman
lgtm http://codereview.chromium.org/10834355/diff/5/ipc/ipc_sync_channel.cc File ipc/ipc_sync_channel.cc (right): http://codereview.chromium.org/10834355/diff/5/ipc/ipc_sync_channel.cc#newcode379 ipc/ipc_sync_channel.cc:379: #if !defined(OS_ANDROID) && !defined(OS_NACL) Can you add a ...
8 years, 4 months ago (2012-08-16 17:57:10 UTC) #2
Bernhard Bauer
http://codereview.chromium.org/10834355/diff/5/ipc/ipc_sync_channel.cc File ipc/ipc_sync_channel.cc (right): http://codereview.chromium.org/10834355/diff/5/ipc/ipc_sync_channel.cc#newcode379 ipc/ipc_sync_channel.cc:379: #if !defined(OS_ANDROID) && !defined(OS_NACL) On 2012/08/16 17:57:10, piman wrote: ...
8 years, 4 months ago (2012-08-16 19:14:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10834355/7
8 years, 4 months ago (2012-08-16 19:14:51 UTC) #4
commit-bot: I haz the power
Change committed as 151975
8 years, 4 months ago (2012-08-16 21:37:32 UTC) #5
piman
On 2012/08/16 21:37:32, I haz the power (commit-bot) wrote: > Change committed as 151975 FYI, ...
8 years, 4 months ago (2012-08-17 21:11:49 UTC) #6
Bernhard Bauer
PTAL. I removed the stack traces but kept the rest so we don't spam all ...
8 years, 4 months ago (2012-08-20 14:34:01 UTC) #7
piman
lgtm
8 years, 4 months ago (2012-08-20 16:41:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10834355/7002
8 years, 4 months ago (2012-08-20 16:42:57 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:10:10 UTC) #10
Change committed as 152395

Powered by Google App Engine
This is Rietveld 408576698