Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3049)

Unified Diff: chrome/browser/sync/profile_sync_service_unittest.cc

Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore expectations in DTMImpl unittest + Treat observer_ as const Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_unittest.cc b/chrome/browser/sync/profile_sync_service_unittest.cc
index 1a2fe90cbe7d9470732d7bb7c286e64aaa8aa700..bf9916c50f034365fe1ad71164c177b71dda8d65 100644
--- a/chrome/browser/sync/profile_sync_service_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_unittest.cc
@@ -116,7 +116,7 @@ class ProfileSyncServiceTest : public testing::Test {
profile_->GetPrefs()->SetBoolean(prefs::kSyncHasSetupCompleted, false);
// Register the bookmark data type.
- ON_CALL(*factory, CreateDataTypeManager(_, _)).
+ ON_CALL(*factory, CreateDataTypeManager(_, _, _)).
WillByDefault(ReturnNewDataTypeManager());
if (issue_auth_token) {
@@ -192,7 +192,7 @@ TEST_F(ProfileSyncServiceTest, AbortedByShutdown) {
ProfileSyncService::AUTO_START,
true,
base::Closure()));
- EXPECT_CALL(*factory, CreateDataTypeManager(_, _)).Times(0);
+ EXPECT_CALL(*factory, CreateDataTypeManager(_, _, _)).Times(0);
EXPECT_CALL(*factory, CreateBookmarkSyncComponents(_, _)).
Times(0);
service_->RegisterDataTypeController(
@@ -217,7 +217,7 @@ TEST_F(ProfileSyncServiceTest, DisableAndEnableSyncTemporarily) {
true,
base::Closure()));
// Register the bookmark data type.
- EXPECT_CALL(*factory, CreateDataTypeManager(_, _)).
+ EXPECT_CALL(*factory, CreateDataTypeManager(_, _, _)).
WillRepeatedly(ReturnNewDataTypeManager());
IssueTestTokens();
« no previous file with comments | « chrome/browser/sync/profile_sync_service_typed_url_unittest.cc ('k') | chrome/browser/sync/test_profile_sync_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698