Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/sync/profile_sync_service_preference_unittest.cc

Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore expectations in DTMImpl unittest + Treat observer_ as const Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <string> 6 #include <string>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 ProfileSyncService::AUTO_START, 126 ProfileSyncService::AUTO_START,
127 false, 127 false,
128 callback)); 128 callback));
129 pref_sync_service_ = reinterpret_cast<PrefModelAssociator*>( 129 pref_sync_service_ = reinterpret_cast<PrefModelAssociator*>(
130 prefs_->GetSyncableService()); 130 prefs_->GetSyncableService());
131 if (!pref_sync_service_) 131 if (!pref_sync_service_)
132 return false; 132 return false;
133 EXPECT_CALL(*factory, GetSyncableServiceForType(syncer::PREFERENCES)). 133 EXPECT_CALL(*factory, GetSyncableServiceForType(syncer::PREFERENCES)).
134 WillOnce(Return(pref_sync_service_->AsWeakPtr())); 134 WillOnce(Return(pref_sync_service_->AsWeakPtr()));
135 135
136 EXPECT_CALL(*factory, CreateDataTypeManager(_, _)). 136 EXPECT_CALL(*factory, CreateDataTypeManager(_, _, _)).
137 WillOnce(ReturnNewDataTypeManager()); 137 WillOnce(ReturnNewDataTypeManager());
138 dtc_ = new UIDataTypeController(syncer::PREFERENCES, 138 dtc_ = new UIDataTypeController(syncer::PREFERENCES,
139 factory, 139 factory,
140 profile_.get(), 140 profile_.get(),
141 service_.get()); 141 service_.get());
142 EXPECT_CALL(*factory, CreateSharedChangeProcessor()). 142 EXPECT_CALL(*factory, CreateSharedChangeProcessor()).
143 WillOnce(Return(new SharedChangeProcessor())); 143 WillOnce(Return(new SharedChangeProcessor()));
144 EXPECT_CALL(*factory, CreateGenericChangeProcessor(_, _, _)). 144 EXPECT_CALL(*factory, CreateGenericChangeProcessor(_, _, _)).
145 WillOnce(CreateAndSaveChangeProcessor(&change_processor_)); 145 WillOnce(CreateAndSaveChangeProcessor(&change_processor_));
146 service_->RegisterDataTypeController(dtc_); 146 service_->RegisterDataTypeController(dtc_);
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 EXPECT_FALSE(pref->IsDefaultValue()); 575 EXPECT_FALSE(pref->IsDefaultValue());
576 // There should be no synced value. 576 // There should be no synced value.
577 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 577 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
578 // Switch kHomePage back to unmanaged. 578 // Switch kHomePage back to unmanaged.
579 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage); 579 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage);
580 // The original value should be picked up. 580 // The original value should be picked up.
581 EXPECT_TRUE(pref->IsDefaultValue()); 581 EXPECT_TRUE(pref->IsDefaultValue());
582 // There should still be no synced value. 582 // There should still be no synced value.
583 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 583 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
584 } 584 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698