Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: chrome/browser/sync/profile_sync_components_factory_impl.h

Issue 10834351: [sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeMa… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore expectations in DTMImpl unittest + Treat observer_ as const Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 11 matching lines...) Expand all
22 class ProfileSyncComponentsFactoryImpl : public ProfileSyncComponentsFactory { 22 class ProfileSyncComponentsFactoryImpl : public ProfileSyncComponentsFactory {
23 public: 23 public:
24 ProfileSyncComponentsFactoryImpl(Profile* profile, 24 ProfileSyncComponentsFactoryImpl(Profile* profile,
25 CommandLine* command_line); 25 CommandLine* command_line);
26 virtual ~ProfileSyncComponentsFactoryImpl(); 26 virtual ~ProfileSyncComponentsFactoryImpl();
27 27
28 virtual void RegisterDataTypes(ProfileSyncService* pss) OVERRIDE; 28 virtual void RegisterDataTypes(ProfileSyncService* pss) OVERRIDE;
29 29
30 virtual browser_sync::DataTypeManager* CreateDataTypeManager( 30 virtual browser_sync::DataTypeManager* CreateDataTypeManager(
31 browser_sync::SyncBackendHost* backend, 31 browser_sync::SyncBackendHost* backend,
32 const browser_sync::DataTypeController::TypeMap* controllers) OVERRIDE; 32 const browser_sync::DataTypeController::TypeMap* controllers,
33 browser_sync::DataTypeManagerObserver* observer) OVERRIDE;
33 34
34 virtual browser_sync::GenericChangeProcessor* CreateGenericChangeProcessor( 35 virtual browser_sync::GenericChangeProcessor* CreateGenericChangeProcessor(
35 ProfileSyncService* profile_sync_service, 36 ProfileSyncService* profile_sync_service,
36 browser_sync::DataTypeErrorHandler* error_handler, 37 browser_sync::DataTypeErrorHandler* error_handler,
37 const base::WeakPtr<syncer::SyncableService>& local_service) OVERRIDE; 38 const base::WeakPtr<syncer::SyncableService>& local_service) OVERRIDE;
38 39
39 virtual browser_sync::SharedChangeProcessor* 40 virtual browser_sync::SharedChangeProcessor*
40 CreateSharedChangeProcessor() OVERRIDE; 41 CreateSharedChangeProcessor() OVERRIDE;
41 42
42 virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType( 43 virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 // Set on the UI thread (since extensions::ExtensionSystemFactory is 75 // Set on the UI thread (since extensions::ExtensionSystemFactory is
75 // non-threadsafe); accessed on both the UI and FILE threads in 76 // non-threadsafe); accessed on both the UI and FILE threads in
76 // GetSyncableServiceForType. 77 // GetSyncableServiceForType.
77 extensions::ExtensionSystem* extension_system_; 78 extensions::ExtensionSystem* extension_system_;
78 scoped_refptr<WebDataService> web_data_service_; 79 scoped_refptr<WebDataService> web_data_service_;
79 80
80 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl); 81 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl);
81 }; 82 };
82 83
83 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 84 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
OLDNEW
« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory.h ('k') | chrome/browser/sync/profile_sync_components_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698