Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 10834350: Remove all the indexeddb-related utility process code (Closed)

Created:
8 years, 4 months ago by alecflett
Modified:
8 years, 4 months ago
Reviewers:
jam, dgrogan, jsbell, tony
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@opencursor-cleanup
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated against trunk, disabled one test #

Total comments: 2

Patch Set 3 : Removing some cruft #

Total comments: 2

Patch Set 4 : A few more #includes removed #

Patch Set 5 : Rebase, attempt to reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1232 lines) Patch
M content/browser/browser_process_sub_thread.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.cc View 2 chunks +0 lines, -37 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_key_utility_client.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_key_utility_client.cc View 1 chunk +0 lines, -408 lines 0 comments Download
D content/browser/indexed_db/OWNERS View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D content/browser/indexed_db/idbbindingutilities_browsertest.cc View 1 2 1 chunk +0 lines, -440 lines 0 comments Download
M content/common/utility_messages.h View 3 chunks +0 lines, -26 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/ppapi_plugin/ppapi_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 4 chunks +0 lines, -29 lines 0 comments Download
M content/utility/utility_thread_impl.h View 2 chunks +0 lines, -11 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 2 3 3 chunks +0 lines, -32 lines 0 comments Download
M webkit/glue/idb_bindings.h View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M webkit/glue/idb_bindings.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 chunk +0 lines, -8 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 2 chunks +0 lines, -14 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
alecflett
There may be more than this, I'm still cutting away at code, but thought you ...
8 years, 4 months ago (2012-08-17 19:02:36 UTC) #1
dgrogan
lgtm https://chromiumcodereview.appspot.com/10834350/diff/1001/content/content_tests.gypi File content/content_tests.gypi (right): https://chromiumcodereview.appspot.com/10834350/diff/1001/content/content_tests.gypi#newcode576 content/content_tests.gypi:576: # 'browser/indexed_db/idbbindingutilities_browsertest.cc', What's the plan here?
8 years, 4 months ago (2012-08-17 20:15:00 UTC) #2
dgrogan
lgtm http://codereview.chromium.org/10834350/diff/1001/webkit/glue/idb_bindings.h File webkit/glue/idb_bindings.h (right): http://codereview.chromium.org/10834350/diff/1001/webkit/glue/idb_bindings.h#newcode13 webkit/glue/idb_bindings.h:13: namespace webkit_glue { Can you also remove idb_bindings.*?
8 years, 4 months ago (2012-08-17 20:54:51 UTC) #3
alecflett
This next patch removes a little bit more - the empty files that dgrogan noticed ...
8 years, 4 months ago (2012-08-21 18:37:22 UTC) #4
jsbell
lgtm as well, this is awesome https://chromiumcodereview.appspot.com/10834350/diff/1002/content/utility/utility_thread_impl.cc File content/utility/utility_thread_impl.cc (right): https://chromiumcodereview.appspot.com/10834350/diff/1002/content/utility/utility_thread_impl.cc#newcode14 content/utility/utility_thread_impl.cc:14: #include "content/common/indexed_db/indexed_db_key.h" Can ...
8 years, 4 months ago (2012-08-21 18:53:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/10834350/9001
8 years, 4 months ago (2012-08-22 00:28:07 UTC) #6
commit-bot: I haz the power
Presubmit check for 10834350-9001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-22 00:28:27 UTC) #7
alecflett
Darin/John - Mind a review? This is entirely code removal (yay!) now that I've refactored ...
8 years, 4 months ago (2012-08-22 00:37:49 UTC) #8
jam
lgtm
8 years, 4 months ago (2012-08-22 01:34:20 UTC) #9
alecflett
oops, darin is on vacation - tony@ mind a review as an OWNER of webkit/ ...
8 years, 4 months ago (2012-08-22 19:11:41 UTC) #10
tony
webkit lgtm
8 years, 4 months ago (2012-08-22 20:51:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/10834350/9001
8 years, 4 months ago (2012-08-22 20:58:00 UTC) #12
commit-bot: I haz the power
Change committed as 152873
8 years, 4 months ago (2012-08-22 23:49:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/10834350/16003
8 years, 4 months ago (2012-08-24 18:32:01 UTC) #14
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 22:57:31 UTC) #15
Change committed as 153336

Powered by Google App Engine
This is Rietveld 408576698