Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 10834341: Remove forced static_library build for Dr. Memory now that the tool (Closed)

Created:
8 years, 4 months ago by Derek Bruening
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove forced static_library build for Dr. Memory now that the tool supports the debug MSVS libc dll. Also disabled debug build inlining and FPO to support increasing debug build optimization. Re-add unit_tests to the "Windows Tests (DrMemory)" bot. (The unit_tests cannot be linked with static_library, which is why they were removed from the bot.) BUG=137180 R=rnk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/common.gypi View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Bruening
8 years, 4 months ago (2012-08-15 20:35:07 UTC) #1
Reid Kleckner (google)
LGTM I assume you're going to submit https://chromiumcodereview.appspot.com/10823349/ first, after its try job finishes. Otherwise ...
8 years, 4 months ago (2012-08-15 21:10:17 UTC) #2
Derek Bruening
8 years, 4 months ago (2012-08-15 21:28:13 UTC) #3
On 2012/08/15 21:10:17, Reid Kleckner (google) wrote:
> > I assume you're going to submit
https://chromiumcodereview.appspot.com/10823349/
> first, after its try job finishes.  Otherwise the m.fyi drmemory bot will
> flicker red.

yes that is the plan

Powered by Google App Engine
This is Rietveld 408576698