Issue 10834338: Move non SystemTray specific code to TrayBackgroundView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834338: Move non SystemTray specific code to TrayBackgroundView (Closed)

Created:
8 years, 4 months ago by stevenjb

Modified:
8 years, 4 months ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move non SystemTray specific code to TrayBackgroundView This fixes the behavior of the web notification tray with launcher auto-hide. It also fixes visibility of the web notification tray in the lock screen. BUG=142506 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151752 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151775

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase #

Patch Set 4 : Fix test #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -86 lines)			Patch
M	ash/system/status_area_widget.cc	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	ash/system/tray/system_tray.h	View		5 chunks	+2 lines, -13 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View		6 chunks	+14 lines, -60 lines	0 comments	Download
M	ash/system/tray/tray_background_view.h	View		6 chunks	+17 lines, -4 lines	0 comments	Download
M	ash/system/tray/tray_background_view.cc	View	1 2 3	5 chunks	+56 lines, -1 line	0 comments	Download
M	ash/system/web_notification/web_notification_tray.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/web_notification/web_notification_tray.cc	View		3 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

Pulled out about half of the changes from 10836227 into this CL. Ready for review.

8 years, 4 months ago (2012-08-15 18:08:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10834338/2001

8 years, 4 months ago (2012-08-15 18:44:15 UTC) #3

commit-bot: I haz the power

8 years, 4 months ago (2012-08-15 19:40:31 UTC) #4

Try job failure for 10834338-2001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages