Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10834315: Add app ID to the TCP/UDP socket API whitelist (Closed)

Created:
8 years, 4 months ago by Stephen
Modified:
8 years, 4 months ago
Reviewers:
brettw, Jamie
CC:
chromium-reviews
Visibility:
Public.

Description

Add app ID to the TCP/UDP socket API whitelist Contributed by skonig@chromium.org BUG=142514 TEST="Manual - run the app without the app ID added to the whitelist and confirm it fails. Then run again with app ID added to the whitelist and confirm it works." Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Stephen
8 years, 4 months ago (2012-08-14 19:26:28 UTC) #1
Jamie
lgtm
8 years, 4 months ago (2012-08-14 19:29:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skonig@chromium.org/10834315/1
8 years, 4 months ago (2012-08-14 19:29:54 UTC) #3
commit-bot: I haz the power
Presubmit check for 10834315-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-14 19:29:56 UTC) #4
Stephen
8 years, 4 months ago (2012-08-14 19:51:56 UTC) #5
brettw
lgtm rubberstamp.
8 years, 4 months ago (2012-08-14 19:53:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skonig@chromium.org/10834315/1
8 years, 4 months ago (2012-08-14 19:55:06 UTC) #7
commit-bot: I haz the power
Try job failure for 10834315-1 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 4 months ago (2012-08-14 21:36:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skonig@chromium.org/10834315/1
8 years, 4 months ago (2012-08-14 21:58:56 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 00:24:41 UTC) #10
Change committed as 151616

Powered by Google App Engine
This is Rietveld 408576698