Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: net/base/network_delegate.h

Issue 10834313: Add histograms for network activity, and total/cumulative (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/shell_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_delegate.h
===================================================================
--- net/base/network_delegate.h (revision 152373)
+++ net/base/network_delegate.h (working copy)
@@ -48,10 +48,12 @@
};
typedef base::Callback<void(AuthRequiredResponse)> AuthCallback;
- enum CacheWaitState {
- CACHE_WAIT_STATE_START,
- CACHE_WAIT_STATE_FINISH,
- CACHE_WAIT_STATE_RESET
+ enum RequestWaitState {
+ REQUEST_WAIT_STATE_CACHE_START,
+ REQUEST_WAIT_STATE_CACHE_FINISH,
+ REQUEST_WAIT_STATE_NETWORK_START,
+ REQUEST_WAIT_STATE_NETWORK_FINISH,
+ REQUEST_WAIT_STATE_RESET
};
virtual ~NetworkDelegate() {}
@@ -96,8 +98,8 @@
int NotifyBeforeSocketStreamConnect(SocketStream* socket,
const CompletionCallback& callback);
- void NotifyCacheWaitStateChange(const URLRequest& request,
- CacheWaitState state);
+ void NotifyRequestWaitStateChange(const URLRequest& request,
+ RequestWaitState state);
private:
// This is the interface for subclasses of NetworkDelegate to implement. These
@@ -225,15 +227,11 @@
SocketStream* socket, const CompletionCallback& callback) = 0;
// Called when the completion of a URLRequest is blocking on a cache
- // transaction (CACHE_WAIT_STATE_START), or when a URLRequest is no longer
- // blocked on a cache transaction (CACHE_WAIT_STATE_FINISH), or when a
- // URLRequest is reset (CACHE_WAIT_STATE_RESET), indicating
- // cancellation of any pending cache waits for this request. Notice that
- // START can be called several times for the same request. It is the
- // responsibility of the delegate to keep track of the number of outstanding
- // cache transactions.
- virtual void OnCacheWaitStateChange(const URLRequest& request,
- CacheWaitState state) = 0;
+ // action or a network action, or when that is no longer the case.
+ // REQUEST_WAIT_STATE_RESET indicates for a given URLRequest
+ // cancellation of any pending waits for this request.
+ virtual void OnRequestWaitStateChange(const URLRequest& request,
+ RequestWaitState state) = 0;
};
} // namespace net
« no previous file with comments | « content/shell/shell_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698