Issue 10834312: Make net-internals work a bit better on Android.

Issue 10834312: Make net-internals work a bit better on Android. (Closed)

Created:
8 years, 4 months ago by mmenke

Modified:
8 years, 4 months ago

Reviewers:
eroman

CC:
chromium-reviews, tfarina, arv (Not doing code reviews), eroman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make net-internals work a bit better on Android. - Prevent automatic font downscaling. - Use font sizes in percents rather than pixels. - Use em for spacing around tabs on the left, rather than pixels. Pixels still used in most other places for padding. - Sliders are now wider on devices with touchscreens, and support touching. BUG=139866 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151881

Patch Set 1 #

Patch Set 2 : Minor fixups #

Total comments: 3

Patch Set 3 : Add missing file #

Patch Set 4 : sync #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -51 lines)			Patch
M	chrome/browser/resources/net_internals/events_view.css	View	1 2 3	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/net_internals/import_view.html	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/index.html	View	1 2 3	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.css	View	1 2 3	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/proxy_view.html	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/resizable_vertical_split_view.js	View	1 2 3	3 chunks	+72 lines, -26 lines	0 comments	Download
M	chrome/browser/resources/net_internals/tab_switcher_view.css	View	1 2 3	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/net_internals/timeline_graph_view.js	View	1 2 3	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/net_internals/util.js	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mmenke

If you want to see what it looks like, you can go to http://www.corp.google.com/~mmenke/net-internals.htm#import and ...

8 years, 4 months ago (2012-08-14 20:10:31 UTC) #1

If you want to see what it looks like, you can go to
http://www.corp.google.com/~mmenke/net-internals.htm#import and play around with
it a bit.  Pressing "Load Test Dump" on the import tab will load a test dump,
since you normally can't load logs on Android.

It should look and work exactly as will in the browser on Windows and Android
(Except without any events from the browser, of course).  Font choices may be
wrong on other platforms.

With this CL, all screens are pretty usable on the Nexus 7, and all except
#events and #timeline can be managed on a Galaxy Nexus.  Nexus S doesn't work so
well.

Other things that are still needed:
1)  Some way to upload log dumps from Android.
2)  Be nice to use a vertical split on the events and timeline views on Android,
maybe based on width / height ratio, or width / font size ratio.  With this,
every tab should be usable, if not a joy to use, on the Galaxy Nexus.
3)  Hide tabs on the left on touch devices / small screens.  This would probably
make it somewhat usable on the Nexus S.  Alternatively, hide everything but the
export view on really small screens.
4)  Timeline view doesn't support touch.

Of those, 1) clearly has the highest priority.  3) may be needed just to be able
to upload a log on a Nexus S as well.

2) and 4) are lower priority.  They're also the easiest to do.

http://codereview.chromium.org/10834312/diff/7001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/events_view.css (left):

http://codereview.chromium.org/10834312/diff/7001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/events_view.css:15: font-size: 12px;
Putting a % size in here multiplied by the percent for every descendant in the
DOM.

http://codereview.chromium.org/10834312/diff/7001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/index.html (left):

http://codereview.chromium.org/10834312/diff/7001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/index.html:8: <head
i18n-values="dir:textdirection;">
Using ltr with english text isn't readable...  And we were applying it to just
the head, rather than the body, which seems a little weird.

http://codereview.chromium.org/10834312/diff/7001/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/timeline_graph_view.js (right):

http://codereview.chromium.org/10834312/diff/7001/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/timeline_graph_view.js:389:
drawTimeLabels: function(context, width, height, textHeight, startTime) {
Some fonts have an ascent above the font's height.  If the font has any such
space, it's non-trivial to figure out from the canvas element.

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10834312/6003

8 years, 4 months ago (2012-08-15 17:07:50 UTC) #3

mmenke

On 2012/08/15 16:47:28, eroman wrote: > lgtm Thanks. Review was more than fast enough for ...

8 years, 4 months ago (2012-08-15 17:08:44 UTC) #4

commit-bot: I haz the power

Try job failure for 10834312-6003 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...

8 years, 4 months ago (2012-08-15 18:45:52 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10834312/6003

8 years, 4 months ago (2012-08-16 02:52:18 UTC) #6

commit-bot: I haz the power

8 years, 4 months ago (2012-08-16 06:28:42 UTC) #7

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

Expand Messages | Collapse Messages