Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: vm/compiler.cc

Issue 10834311: Split ToDouble into two IL instruction to make it work with SSA. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | vm/flow_graph_optimizer.cc » ('j') | vm/flow_graph_optimizer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 OS::Print("--> '%s' entry: 0x%x\n", 398 OS::Print("--> '%s' entry: 0x%x\n",
399 function.ToFullyQualifiedCString(), 399 function.ToFullyQualifiedCString(),
400 Code::Handle(function.CurrentCode()).EntryPoint()); 400 Code::Handle(function.CurrentCode()).EntryPoint());
401 } 401 }
402 if (Isolate::Current()->debugger()->IsActive()) { 402 if (Isolate::Current()->debugger()->IsActive()) {
403 Isolate::Current()->debugger()->NotifyCompilation(function); 403 Isolate::Current()->debugger()->NotifyCompilation(function);
404 } 404 }
405 if (FLAG_disassemble) { 405 if (FLAG_disassemble) {
406 DisassembleCode(function, optimized); 406 DisassembleCode(function, optimized);
407 } else if (FLAG_disassemble_optimized && optimized) { 407 } else if (FLAG_disassemble_optimized && optimized) {
408 // Print unoptimized code along with the optimized code. 408 // TODO(fschneider): Print unoptimized code along with the optimized code.
srdjan 2012/08/14 21:21:26 Why did you remove it if you added a TODO? Did the
Florian Schneider 2012/08/15 10:27:23 The ia32 disassembler does not work for unoptimize
409 DisassembleCode(function, false);
410 DisassembleCode(function, true); 409 DisassembleCode(function, true);
411 } 410 }
412 isolate->set_long_jump_base(base); 411 isolate->set_long_jump_base(base);
413 return Error::null(); 412 return Error::null();
414 } else { 413 } else {
415 Error& error = Error::Handle(); 414 Error& error = Error::Handle();
416 // We got an error during compilation. 415 // We got an error during compilation.
417 error = isolate->object_store()->sticky_error(); 416 error = isolate->object_store()->sticky_error();
418 isolate->object_store()->clear_sticky_error(); 417 isolate->object_store()->clear_sticky_error();
419 isolate->set_long_jump_base(base); 418 isolate->set_long_jump_base(base);
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 result = isolate->object_store()->sticky_error(); 531 result = isolate->object_store()->sticky_error();
533 isolate->object_store()->clear_sticky_error(); 532 isolate->object_store()->clear_sticky_error();
534 isolate->set_long_jump_base(base); 533 isolate->set_long_jump_base(base);
535 return result.raw(); 534 return result.raw();
536 } 535 }
537 UNREACHABLE(); 536 UNREACHABLE();
538 return Object::null(); 537 return Object::null();
539 } 538 }
540 539
541 } // namespace dart 540 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | vm/flow_graph_optimizer.cc » ('j') | vm/flow_graph_optimizer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698