Issue 10834304: Handle trashed file properly (Drive V2 API)

Issue 10834304: Handle trashed file properly (Drive V2 API) (Closed)

Created:
8 years, 4 months ago by kochi

Modified:
8 years, 4 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle trashed file properly (Drive V2 API) BUG=chromium:142580 TEST=manually check if trashed file doesn't appear in file browser. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151455

Patch Set 2 : update comments. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_wapi_parser.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hashimoto

https://chromiumcodereview.appspot.com/10834304/diff/1/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc File chrome/browser/chromeos/gdata/gdata_wapi_parser.cc (right): https://chromiumcodereview.appspot.com/10834304/diff/1/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc#newcode828 chrome/browser/chromeos/gdata/gdata_wapi_parser.cc:828: entry->deleted_ = file.labels().is_trashed(); Could you add a brief comment ...

8 years, 4 months ago (2012-08-14 10:21:51 UTC) #2

kochi

Thanks for the review! https://chromiumcodereview.appspot.com/10834304/diff/1/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc File chrome/browser/chromeos/gdata/gdata_wapi_parser.cc (right): https://chromiumcodereview.appspot.com/10834304/diff/1/chrome/browser/chromeos/gdata/gdata_wapi_parser.cc#newcode828 chrome/browser/chromeos/gdata/gdata_wapi_parser.cc:828: entry->deleted_ = file.labels().is_trashed(); Updated comments. ...

8 years, 4 months ago (2012-08-14 10:32:11 UTC) #3

lgtm

Expand Messages | Collapse Messages