Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 10834299: Give time to free the port when shutting down apache on OSX. (Closed)

Created:
8 years, 4 months ago by tony
Modified:
8 years, 4 months ago
Reviewers:
cmp, Peter Mayo
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Give time to free the port when shutting down apache on OSX. Sometimes the next perf test would try to start the http server, but the port wouldn't be available. This matches what we do on Linux. In the long run, we should use a random port to avoid having to wait. BUG=29228 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/python/google/platform_utils_mac.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
8 years, 4 months ago (2012-08-14 00:56:02 UTC) #1
Peter Mayo
lgtm Not completely sure I own enough of this file to lgtm, but the change ...
8 years, 4 months ago (2012-08-14 01:08:10 UTC) #2
cmp
lgtm
8 years, 4 months ago (2012-08-14 02:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10834299/1
8 years, 4 months ago (2012-08-14 03:38:21 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 10:02:01 UTC) #5
Change committed as 151449

Powered by Google App Engine
This is Rietveld 408576698