Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10834297: Change PPB_CharSet_Dev.GetDefaultCharSet to return the default encoding of the web contents instead… (Closed)

Created:
8 years, 4 months ago by yzshen1
Modified:
8 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change PPB_CharSet_Dev.GetDefaultCharSet to return the default encoding of the web contents instead of the Chrome UI. BUG=141110 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yzshen1
Hi, Brett. Would you please take a look? Thanks!
8 years, 4 months ago (2012-08-13 22:25:29 UTC) #1
yzshen1
On 2012/08/13 22:25:29, yzshen1 wrote: > Hi, Brett. > > Would you please take a ...
8 years, 4 months ago (2012-08-15 21:22:51 UTC) #2
brettw
lgtm
8 years, 4 months ago (2012-08-15 21:57:13 UTC) #3
brettw
We should try to get this in M22 since it's so simple.
8 years, 4 months ago (2012-08-15 21:57:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10834297/1
8 years, 4 months ago (2012-08-15 21:59:46 UTC) #5
yzshen1
On 2012/08/15 21:57:29, brettw wrote: > We should try to get this in M22 since ...
8 years, 4 months ago (2012-08-15 21:59:57 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 00:48:47 UTC) #7
Change committed as 151805

Powered by Google App Engine
This is Rietveld 408576698