Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2353)

Unified Diff: build/common.gypi

Issue 10834296: Second attempt at fixing Ninja build for Android and change make for host os optionally use goma (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: simplify changes to just build/common.gyip Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 4165e191f9d9ded80b9de547358e43548d9a7dec..4a973e16cee9e12cb715f84f7c1384ba9ce3a879 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3330,16 +3330,16 @@
['LINK.host', '$(LINK)'],
],
}],
- ['OS=="android" and clang==0 and "<(GENERATOR)"!="ninja"', {
+ ['OS=="android" and clang==0', {
# Hardcode the compiler names in the Makefile so that
# it won't depend on the environment at make time.
'make_global_settings': [
['CC', '<!(/bin/echo -n ${ANDROID_GOMA_WRAPPER} ${ANDROID_TOOLCHAIN}/*-gcc)'],
['CXX', '<!(/bin/echo -n ${ANDROID_GOMA_WRAPPER} ${ANDROID_TOOLCHAIN}/*-g++)'],
['LINK', '<!(/bin/echo -n ${ANDROID_GOMA_WRAPPER} ${ANDROID_TOOLCHAIN}/*-gcc)'],
- ['CC.host', '<!(which gcc)'],
- ['CXX.host', '<!(which g++)'],
- ['LINK.host', '<!(which g++)'],
+ ['CC.host', '<!(/bin/echo -n ${ANDROID_GOMA_WRAPPER} <!(which gcc))'],
+ ['CXX.host', '<!(/bin/echo -n ${ANDROID_GOMA_WRAPPER} <!(which g++))'],
+ ['LINK.host', '<!(/bin/echo -n ${ANDROID_GOMA_WRAPPER} <!(which g++))'],
],
}],
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698