Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc

Issue 10834295: gdata: Make callback parameters mandatory for CloseFile functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system_interface.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc b/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
index a94f261d072a52bd03ad6fd3daa69fa28d6c6fab..08d0937feee080b6f304b17b73df976fd8d8f259 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
@@ -126,7 +126,9 @@ void CallSnapshotFileCallback(
callback.Run(error, final_file_info, local_path, file_ref);
}
-void OnClose(const FilePath& local_path, GDataFileError error_code) {
+// Emits debug log when GDataFileSystem::CloseFile() is complete.
+void EmitDebugLogForCloseFile(const FilePath& local_path,
+ GDataFileError error_code) {
DVLOG(1) << "Closed: " << local_path.AsUTF8Unsafe() << ": " << error_code;
}
@@ -548,7 +550,8 @@ void GDataFileSystemProxy::NotifyCloseFile(const FileSystemURL& url) {
if (!ValidateUrl(url, &file_path))
return;
- file_system_->CloseFile(file_path, FileOperationCallback());
+ file_system_->CloseFile(file_path,
+ base::Bind(&EmitDebugLogForCloseFile, file_path));
}
void GDataFileSystemProxy::CreateSnapshotFile(
@@ -732,7 +735,8 @@ void GDataFileSystemProxy::CloseWritableSnapshotFile(
const FilePath& local_path) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- file_system_->CloseFile(virtual_path, base::Bind(&OnClose, virtual_path));
+ file_system_->CloseFile(virtual_path,
+ base::Bind(&EmitDebugLogForCloseFile, virtual_path));
}
} // namespace gdata
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_file_system_interface.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698