Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 10834295: gdata: Make callback parameters mandatory for CloseFile functions (Closed)

Created:
8 years, 4 months ago by satorux1
Modified:
8 years, 4 months ago
Reviewers:
achuithb
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Make callback parameters mandatory for CloseFile functions There was a place where CloseFile() is called with a null callback, but with the caller fixed, it's safe to make the callback parameter mandatory. Along the way, removed unused |file_path| parameter from DataFileSystem::OnGetEntryCompleteForCloseFile() BUG=126634 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 10 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_interface.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
8 years, 4 months ago (2012-08-13 21:09:38 UTC) #1
achuithb
8 years, 4 months ago (2012-08-13 21:24:50 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698