Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: webkit/glue/resource_loader_bridge.h

Issue 10834289: Split net::UploadData into two: for IPC and for upload handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase + moved ResolveBlobRef from webkit_blob to webkit_glue Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/blob/blob_storage_controller_unittest.cc ('k') | webkit/glue/resource_request_body.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/resource_loader_bridge.h
diff --git a/webkit/glue/resource_loader_bridge.h b/webkit/glue/resource_loader_bridge.h
index 70db933767cda47e9f01be9c883245708b7aa6b3..e699574f965d273cd2fb2552c798d37d78d7a2bc 100644
--- a/webkit/glue/resource_loader_bridge.h
+++ b/webkit/glue/resource_loader_bridge.h
@@ -41,6 +41,7 @@ class HttpResponseHeaders;
}
namespace webkit_glue {
+class ResourceRequestBody;
// Structure containing timing information for the request. It addresses
// http://groups.google.com/group/http-archive-specification/web/har-1-1-spec
@@ -348,32 +349,9 @@ class ResourceLoaderBridge {
// anybody can delete at any time, INCLUDING during processing of callbacks.
WEBKIT_GLUE_EXPORT virtual ~ResourceLoaderBridge();
- // Call this method before calling Start() to append a chunk of binary data
- // to the request body. May only be used with HTTP(S) POST requests.
- virtual void AppendDataToUpload(const char* data, int data_len) = 0;
-
- // Call this method before calling Start() to append the contents of a file
- // to the request body. May only be used with HTTP(S) POST requests.
- void AppendFileToUpload(const FilePath& file_path) {
- AppendFileRangeToUpload(file_path, 0, kuint64max, base::Time());
- }
-
- // Call this method before calling Start() to append the contents of a file
- // to the request body. May only be used with HTTP(S) POST requests.
- virtual void AppendFileRangeToUpload(
- const FilePath& file_path,
- uint64 offset,
- uint64 length,
- const base::Time& expected_modification_time) = 0;
-
- // Call this method before calling Start() to append the contents of a blob
- // to the request body. May only be used with HTTP(S) POST requests.
- virtual void AppendBlobToUpload(const GURL& blob_url) = 0;
-
- // Call this method before calling Start() to assign an upload identifier to
- // this request. This is used to enable caching of POST responses. A value
- // of 0 implies the unspecified identifier.
- virtual void SetUploadIdentifier(int64 identifier) = 0;
+ // Call this method before calling Start() to set the request body.
+ // May only be used with HTTP(S) POST requests.
+ virtual void SetRequestBody(ResourceRequestBody* request_body) = 0;
// Call this method to initiate the request. If this method succeeds, then
// the peer's methods will be called asynchronously to report various events.
« no previous file with comments | « webkit/blob/blob_storage_controller_unittest.cc ('k') | webkit/glue/resource_request_body.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698