Issue 10834283: gesture recognizer: Some cleanup and workaround for a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834283: gesture recognizer: Some cleanup and workaround for a crash. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
varunjain

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gesture recognizer: Some cleanup and workaround for a crash. It's yet unclear how the GR receives two press-events for the same touch-point without a release/cancel-event before the second press, but when that does happen in a release build, try to handle it gracefully instead of crashing. BUG=134486 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151342

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : . #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -40 lines)			Patch
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View		2 chunks	+28 lines, -1 line	0 comments	Download
M	ui/base/gestures/gesture_recognizer_impl.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/base/gestures/gesture_sequence.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	ui/base/gestures/gesture_sequence.cc	View	1	5 chunks	+20 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

The real issue behind the bug is still unclear (perhaps device/driver/X issues), but at least ...

8 years, 4 months ago (2012-08-13 03:13:13 UTC) #1

varunjain

LGTM https://chromiumcodereview.appspot.com/10834283/diff/8001/ui/base/gestures/gesture_sequence.cc File ui/base/gestures/gesture_sequence.cc (right): https://chromiumcodereview.appspot.com/10834283/diff/8001/ui/base/gestures/gesture_sequence.cc#newcode321 ui/base/gestures/gesture_sequence.cc:321: const int point_id = points_[event.touch_id()].point_id(); also change this ...

8 years, 4 months ago (2012-08-13 20:40:44 UTC) #2

sadrul

8 years, 4 months ago (2012-08-13 20:43:55 UTC) #3

Thanks!

http://codereview.chromium.org/10834283/diff/8001/ui/base/gestures/gesture_se...
File ui/base/gestures/gesture_sequence.cc (right):

http://codereview.chromium.org/10834283/diff/8001/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.cc:321: const int point_id =
points_[event.touch_id()].point_id();
On 2012/08/13 20:40:44, varunjain wrote:
> also change this to point.point_id()?

Good point. Done.

Expand Messages | Collapse Messages