Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/ui/omnibox/location_bar_util.h

Issue 10834279: Give request-to-act badges a grey background, and increase spacing to make it fit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Call the right superclass method Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/location_bar_view_gtk.cc ('k') | chrome/browser/ui/omnibox/location_bar_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/location_bar_util.h
diff --git a/chrome/browser/ui/omnibox/location_bar_util.h b/chrome/browser/ui/omnibox/location_bar_util.h
index 29f3abf3531bb749e9d2aa471ab5ecbee8c32933..1f2e15b3ad7c546660cb6cefffa870a058618e76 100644
--- a/chrome/browser/ui/omnibox/location_bar_util.h
+++ b/chrome/browser/ui/omnibox/location_bar_util.h
@@ -6,12 +6,34 @@
#define CHROME_BROWSER_UI_OMNIBOX_LOCATION_BAR_UTIL_H_
#include "base/string16.h"
+#include "third_party/skia/include/core/SkColor.h"
+
+class ExtensionAction;
+
+namespace gfx {
+class Canvas;
+class Rect;
+}
namespace location_bar_util {
// Build a short string to use in keyword-search when the field isn't very big.
string16 CalculateMinString(const string16& description);
+// Paint the background and border for |action| on |tab_id|. |bounds| should
+// include the top and bottom of the location bar, and the middle column
+// exactly between two ExtensionActions, so both ExtensionActions can draw on
+// it. This background is only drawn for script badges in the WANTS_ATTENTION
+// state, and (when text is black and the background is white) consists of a
+// dark grey, 1px border and a lighter grey background with a slight vertical
+// gradient.
+void PaintExtensionActionBackground(const ExtensionAction& action,
+ int tab_id,
+ gfx::Canvas* canvas,
+ const gfx::Rect& bounds,
+ SkColor text_color,
+ SkColor background_color);
+
} // namespace location_bar_util
#endif // CHROME_BROWSER_UI_OMNIBOX_LOCATION_BAR_UTIL_H_
« no previous file with comments | « chrome/browser/ui/gtk/location_bar_view_gtk.cc ('k') | chrome/browser/ui/omnibox/location_bar_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698