Give request-to-act badges a grey background, and increase spacing to make it fit.

chrome/browser/extensions/extension_action_util.cc

Index: chrome/browser/extensions/extension_action_util.cc
diff --git a/chrome/browser/extensions/extension_action_util.cc b/chrome/browser/extensions/extension_action_util.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2460e4ce4cf00b26175bdfb775b4d01a3319e2f3
--- /dev/null
+++ b/chrome/browser/extensions/extension_action_util.cc
@@ -0,0 +1,54 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_action_util.h"
+
+#include "chrome/browser/themes/theme_service.h"
+#include "chrome/common/extensions/extension_action.h"
+#include "third_party/skia/include/core/SkPaint.h"
+#include "third_party/skia/include/effects/SkGradientShader.h"
+#include "ui/gfx/canvas.h"
+#include "ui/gfx/color_utils.h"
+#include "ui/gfx/rect.h"
+
+namespace extensions {
+
+void PaintBackground(const ExtensionAction& action,
+                     int tab_id,
+                     gfx::Canvas* canvas,
+                     const gfx::Rect& bounds,
+                     const ui::ThemeProvider& theme) {
+  if (action.WantsAttention(tab_id)) {
+    SkPoint gradient_bounds[2] = { {SkIntToScalar(bounds.x()),
+                                    SkIntToScalar(bounds.y())},
+                                   {SkIntToScalar(bounds.x()),
+                                    SkIntToScalar(bounds.bottom())} };
+    const SkColor text_color = theme.GetColor(ThemeService::COLOR_NTP_TEXT);

[Jeffrey Yasskin, 2012/09/05 21:10:19]

This isn't exactly right, since chrome-themes can affect the NTP_TEXT and
NTP_BACKGROUND colors, while only system themes can affect the location bar's
text and background. It does give the right colors when either the chrome theme
matches the system theme or the chrome theme is left at the default.

I tried moving LocationBarView::GetColor() to LocationBar, but then I noticed
that it's static and called from several places outside of LocationBarView, so
I'd have to put all three platform implementations directly in LocationBar (or
location_bar_util.cc). This wouldn't be a big problem, except the way
gtk_theme_service.cc gets the system colors is by instantiating a GtkEntry and
asking its colors, and this doesn't work so well in a static function.

Another option is to give the ThemeService some colors specifically for the
location bar, which can't be set by the dynamic theme.

And a third option is to pass the text and background colors into
PaintBackground() and use platform-specific code to pick them.

+    const SkColor background_color =
+        theme.GetColor(ThemeService::COLOR_NTP_BACKGROUND);
+    SkColor gradient_colors[2] = {
+        color_utils::AlphaBlend(text_color, background_color, 0x13),
+        color_utils::AlphaBlend(text_color, background_color, 0x1d)
+    };
+    SkShader* gradient = SkGradientShader::CreateLinear(
+        gradient_bounds, gradient_colors, NULL, 2, SkShader::kClamp_TileMode);
+    SkPaint paint;
+    paint.setShader(gradient);
+    gradient->unref();
+    canvas->DrawRect(bounds, paint);
+
+    SkColor border_color =
+        color_utils::AlphaBlend(text_color, background_color, 0x55);
+    canvas->DrawLine(gfx::Point(bounds.x(), bounds.y()),
+                     gfx::Point(bounds.x(), bounds.bottom()),
+                     border_color);
+    // "-1" because gfx::Rects are half-open, not including their right or
+    // bottom edges.
+    canvas->DrawLine(gfx::Point(bounds.right() - 1, bounds.y()),
+                     gfx::Point(bounds.right() - 1, bounds.bottom()),
+                     border_color);
+  }
+}
+
+}  // namespace extensions