Give request-to-act badges a grey background, and increase spacing to make it fit.

chrome/common/extensions/extension_action.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_ACTION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_ACTION_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 21 matching lines @@
 // ExtensionAction encapsulates the state of a browser action, page action, or
 // script badge.
 // Instances can have both global and per-tab state. If a property does not have
 // a per-tab value, the global value is used instead.
 class ExtensionAction {
  public:
   // Use this ID to indicate the default state for properties that take a tab_id
   // parameter.
   static const int kDefaultTabId;
 
+  static const SkColor kGetAttentionBorderColor;

[Peter Kasting, 2012/08/24 23:08:28]

Nit: Why are these public class members instead of, say, function- or file-scope
constants in the .cc file?

[Jeffrey Yasskin, 2012/08/29 00:37:50]

At one point I was using them from the platform-specific code, but I'm not
anymore.

+  static const SkColor kGetAttentionBackgroundTopColor;
+  static const SkColor kGetAttentionBackgroundBottomColor;
+
   // The types of extension actions.
   enum Type {
     TYPE_BROWSER,
     TYPE_PAGE,
     TYPE_SCRIPT_BADGE,
   };
 
   enum Appearance {
     // The action icon is hidden.
     INVISIBLE,
@@ skipping 177 matching lines @@
   // Set this action's badge visibility on a specific tab.  This takes
   // care of any appropriate transition animations.  Returns true if
   // the appearance has changed.
   bool SetAppearance(int tab_id, Appearance value);
   // Get the badge visibility for a tab, or the default badge visibility
   // if none was set.
   bool GetIsVisible(int tab_id) const {
     return GetValue(&appearance_, tab_id) != INVISIBLE;
   }
 
+  // True if the tab's action wants the user's attention.
+  bool WantsAttention(int tab_id) const {
+    return GetValue(&appearance_, tab_id) == WANTS_ATTENTION;
+  }
+
   // Remove all tab-specific state.
   void ClearAllValuesForTab(int tab_id);
 
+  // Paint the background and border for |tab_id|.  |bounds| should include the
+  // top and bottom of the location bar, and the middle column exactly between
+  // two ExtensionActions, so both ExtensionActions can draw on it.

[Peter Kasting, 2012/08/24 23:08:28]

Nit: You might want to note in this comment what sort of background we're
painting (e.g. that only WantsAttention() cases get a background at all, and
what it looks like).

[Jeffrey Yasskin, 2012/08/29 00:37:50]

Done.

+  void PaintBackground(gfx::Canvas* canvas, const gfx::Rect& bounds,

[Peter Kasting, 2012/08/24 23:08:28]

Nit: One line per arg

[Jeffrey Yasskin, 2012/08/29 00:37:50]

Oops, done.

+                       int tab_id);
+
   // If the specified tab has a badge, paint it into the provided bounds.
   void PaintBadge(gfx::Canvas* canvas, const gfx::Rect& bounds, int tab_id);
 
   // Returns icon image with badge for specified tab.
   gfx::ImageSkia GetIconWithBadge(const gfx::ImageSkia& icon,
                                   int tab_id,
                                   const gfx::Size& spacing) const;
 
   // Gets a weak reference to the icon animation for a tab, if any. The
   // reference will only have a value while the animation is running.
@@ skipping 93 matching lines @@
 };
 
 template<>
 struct ExtensionAction::ValueTraits<int> {
   static int CreateEmpty() {
     return -1;
   }
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_ACTION_H_