Give request-to-act badges a grey background, and increase spacing to make it fit.

chrome/common/extensions/extension_action.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_action.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "chrome/common/badge_util.h"
@@ skipping 173 matching lines @@
   // Color of badge text.
   SkColor text_color_;
   // Color of the badge.
   SkColor background_color_;
 
   DISALLOW_COPY_AND_ASSIGN(IconWithBadgeImageSource);
 };
 
 
 const int ExtensionAction::kDefaultTabId = -1;
+const SkColor ExtensionAction::kGetAttentionBorderColor =

[Peter Kasting, 2012/08/24 23:08:28]

You need to get the correct colors from the theming system, as the omnibox
borders and background colors can be anything.

[Jeffrey Yasskin, 2012/08/29 00:37:50]

Oh good. I'll figure out how to do this after sending off this reply.

+    SkColorSetRGB(0xAA, 0xAA, 0xAA);
+const SkColor ExtensionAction::kGetAttentionBackgroundTopColor =
+    SkColorSetRGB(0xEC, 0xEC, 0xEC);
+const SkColor ExtensionAction::kGetAttentionBackgroundBottomColor =
+    SkColorSetRGB(0xE2, 0xE2, 0xE2);
 
 ExtensionAction::IconAnimation::IconAnimation(
     ui::AnimationDelegate* delegate)
     // 100ms animation at 50fps (so 5 animation frames in total).
     : ui::LinearAnimation(100, 50, delegate) {}
 
 ExtensionAction::IconAnimation::~IconAnimation() {}
 
 const SkBitmap& ExtensionAction::IconAnimation::Apply(
     const SkBitmap& icon) const {
@@ skipping 159 matching lines @@
   title_.erase(tab_id);
   icon_.erase(tab_id);
   icon_index_.erase(tab_id);
   badge_text_.erase(tab_id);
   badge_text_color_.erase(tab_id);
   badge_background_color_.erase(tab_id);
   appearance_.erase(tab_id);
   icon_animation_.erase(tab_id);
 }
 
+void ExtensionAction::PaintBackground(gfx::Canvas* canvas,
+                                      const gfx::Rect& bounds,
+                                      int tab_id) {
+  if (WantsAttention(tab_id)) {
+    SkPoint gradient_bounds[2] = { {SkIntToScalar(bounds.x()),
+                                    SkIntToScalar(bounds.y() + 1)},

[Peter Kasting, 2012/08/24 23:08:28]

Nit: Once you've defined LocationBar::kVisibleEdgeThickness (see
location_bar_view.cc), you can subtract that off here instead of just "-1".

[Jeffrey Yasskin, 2012/08/29 00:37:50]

This isn't necessarily the thickness of the location bar edge, it's the
thickness of the request-to-act background's edge. Also, the top and bottom
edges of the location bar are different thicknesses, in different directions
depending on the platform.

I could instead make a png for the background, check it into  the themes
directory, and stamp it onto the canvas? I'm not sure if I should use
Canvas::DrawImageInt or SkCanvas::drawBitmapNine in that case.

+                                   {SkIntToScalar(bounds.x()),
+                                    SkIntToScalar(bounds.bottom() - 1)} };
+    SkColor gradient_colors[2] = { kGetAttentionBackgroundTopColor,
+                                   kGetAttentionBackgroundBottomColor };
+    SkShader* gradient = SkGradientShader::CreateLinear(
+        gradient_bounds, gradient_colors, NULL, 2, SkShader::kClamp_TileMode);
+    SkPaint paint;
+    paint.setShader(gradient);
+    gradient->unref();
+    gfx::Rect bg_rect(bounds.x() - 1, bounds.y(),

[Peter Kasting, 2012/08/24 23:08:28]

Why do we draw outside our bounds?  Shouldn't our bounds include the whole area
we draw on?

[Jeffrey Yasskin, 2012/08/29 00:37:50]

I think this came from before I had the platform-specific code setting the
bounds in the right way. Fixed.

+                      bounds.width() + 1, bounds.height() - 1);

[Peter Kasting, 2012/08/24 23:08:28]

What's this last -1 mean?

[Jeffrey Yasskin, 2012/08/29 00:37:50]

This also came from before I got the platform-specific code in its current form.
Somehow I got the impression that the bounds specified in widget locations
extend one past the right and bottom edges, but DrawRect draws exactly on the
specified rectangle, which meant that the rectangle here needed to be one pixel
smaller than the bounds.

Now the platform-specific code sets these bounds to point at the pixels that
should be used for the border, so there's no need to adjust them here anymore.
The gradient keeps its -1 since I shouldn't have included the border in its
endpoints in the first place.

+    canvas->DrawRect(bg_rect, paint);
+    canvas->DrawRect(bg_rect, kGetAttentionBorderColor);
+  }
+}
+
 void ExtensionAction::PaintBadge(gfx::Canvas* canvas,
                                  const gfx::Rect& bounds,
                                  int tab_id) {
   ExtensionAction::DoPaintBadge(
       canvas,
       bounds,
       GetBadgeText(tab_id),
       GetBadgeTextColor(tab_id),
       GetBadgeBackgroundColor(tab_id),
       GetValue(&icon_, tab_id).size().width());
@@ skipping 138 matching lines @@
       new AnimatedIconImageSource(icon, animation_wrapper->animation()),
       icon.size());
 }
 
 void ExtensionAction::RunIconAnimation(int tab_id) {
   IconAnimationWrapper* icon_animation =
       new IconAnimationWrapper();
   icon_animation_[tab_id] = icon_animation->AsWeakPtr();
   icon_animation->animation()->Start();
 }